Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependabot to update go mod and github action dependencies #1770

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Add dependabot to update go mod and github action dependencies #1770

merged 1 commit into from
Nov 4, 2024

Conversation

savitaashture
Copy link
Contributor

Changes

Adding dependabot so that go mod dependancies updates when there is a new version

Signed-off-by: Savita Ashture [email protected]

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 29, 2024
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 29, 2024
@savitaashture savitaashture requested review from dibyom and vdemeester and removed request for bobcatfish September 29, 2024 18:37
@khrm
Copy link
Contributor

khrm commented Sep 30, 2024

Last time we did this, it caused too many updates.
That's why we disabled this. We get security updates anyway.

khrm
khrm reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this might cause use to go out of sync with pipelines knative/pkg or some deps.

@savitaashture
Copy link
Contributor Author

Also, this might cause use to go out of sync with pipelines knative/pkg or some deps.

how about ignoring kntive/pkg as well similar to k8s
but we can accept PR related to other deps like other Projects and also Pipeline updates
WDYT ?

@vdemeester
Copy link
Member

how about ignoring kntive/pkg as well similar to k8s

Yes, this is what we do in tektoncd/pipeline btw.

vdemeester
vdemeester reviewed Sep 30, 2024
View reviewed changes
.github/dependabot.yml Outdated
- package-ecosystem: "gomod"
directory: "/"
schedule:
interval: "daily"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be changed to weekly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@savitaashture savitaashture force-pushed the add_dependabot_triggers branch from bf5edc9 to b0ea32f Compare September 30, 2024 18:15
@savitaashture
Copy link
Contributor Author

/test tekton-triggers-unit-tests

@savitaashture
Copy link
Contributor Author

how about ignoring kntive/pkg as well similar to k8s

Yes, this is what we do in tektoncd/pipeline btw.

Updated now PTAL thank you

@khrm
Copy link
Contributor

khrm commented Nov 4, 2024

/approve

@khrm
Copy link
Contributor

khrm commented Nov 4, 2024

/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Nov 4, 2024
@tekton-robot tekton-robot merged commit 9c8ae74 into tektoncd:main Nov 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khrm khrm khrm left review comments

@vdemeester vdemeester vdemeester approved these changes

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@khrm khrm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@savitaashture @khrm @vdemeester @tekton-robot