Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cloudevents resource with task from hub #1524

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Feb 9, 2023

Changes

Cloud events pipeline resource was removed from pipelines recently. Our E2E
tests run against the main branch of pipelines and that the getting-started
tutorial still uses this resource, our e2e tests have been failing.

Fixes #1522

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 9, 2023
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 9, 2023
@dibyom
Copy link
Member Author

dibyom commented Feb 9, 2023

/test pull-tekton-triggers-integration-tests

Cloud events pipeline resource was removed from pipelines recently. Our E2E
tests run against the main branch of pipelines and that the getting-started
tutorial still uses this resource, our e2e tests have been failing.

Fixes tektoncd#1522

Signed-off-by: Dibyo Mukherjee <[email protected]>
@dibyom
Copy link
Member Author

dibyom commented Feb 9, 2023

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 9, 2023
@dibyom dibyom marked this pull request as ready for review February 9, 2023 23:40
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2023
@tekton-robot tekton-robot requested a review from khrm February 9, 2023 23:40
@dibyom
Copy link
Member Author

dibyom commented Feb 9, 2023

@savitaashture @khrm please take a look. This should unblock the other PRs

@dibyom
Copy link
Member Author

dibyom commented Feb 10, 2023

/test tekton-triggers-unit-tests

Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2023
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2023
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm, savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 2a2e82f into tektoncd:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace cloud event resource usage
4 participants