-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace cloudevents resource with task from hub #1524
Conversation
Skipping CI for Draft Pull Request. |
/test pull-tekton-triggers-integration-tests |
Cloud events pipeline resource was removed from pipelines recently. Our E2E tests run against the main branch of pipelines and that the getting-started tutorial still uses this resource, our e2e tests have been failing. Fixes tektoncd#1522 Signed-off-by: Dibyo Mukherjee <[email protected]>
/kind bug |
@savitaashture @khrm please take a look. This should unblock the other PRs |
/test tekton-triggers-unit-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thank you
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khrm, savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Cloud events pipeline resource was removed from pipelines recently. Our E2E
tests run against the main branch of pipelines and that the getting-started
tutorial still uses this resource, our e2e tests have been failing.
Fixes #1522
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes