Renames examples rolebinding & clusterrolebinding #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XS
As now we package roles required for eventlistener with release yaml the references in examples/rbac.yaml has been updated with new clusterroles. But if a user has already applied older rbac on the cluster and then try to install from upstream/main it would fail as the references are changed. So, this renames the binding names so that user doesn't face any issue with the upcoming releases. Signed-off-by: Shivam Mukhade <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As now we package roles required for eventlistener with release yaml
the references in examples/rbac.yaml has been updated with new
clusterroles.
But if a user has already applied older rbac on the cluster and then
try to install from upstream/main it would fail as the references
are changed.
So, this renames the binding names so that user doesn't face any issue
with the upcoming releases.
Ref. #1184
Signed-off-by: Shivam Mukhade [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes