Refactor the way Triggers creates child resources to follow Knative conventions #1205
Conversation
tekton-robot
added
release-note-none
tekton-robot
added
the
size/XXL
|
The following is the coverage report on the affected files.
|
mattmoor
changed the title
tekton-robot
added
the
do-not-merge/work-in-progress
mattmoor
force-pushed
the
resources-directory
branch
from
7094cbc to
042dc86
Compare
|
The following is the coverage report on the affected files.
|
mattmoor
force-pushed
the
resources-directory
branch
from
042dc86 to
c3fd34b
Compare
|
The following is the coverage report on the affected files.
|
…onventions.
Generally in Knative our controller structure follows the layout:
```
pkg/
reconciler/
{resource-name}/
controller.go # The *controller.Impl ctor (deals with informers and workqueues)
{resource-name}.go # The typed reconciler (deals with listers and clients)
resources/
{child-resource-name}.go # Logic for building this child resource.
...
names/
names.go # Optionally holds methods for naming child resources.
```
The main piece of this that this change start to move things towards is the
`resources/` sub-directory (I did not start a `names/` sub-directory).
mattmoor
force-pushed
the
resources-directory
branch
from
c3fd34b to
f8bae70
Compare
|
The following is the coverage report on the affected files.
|
|
Nice! The folder structure makes sense! |
|
I've been pushing progress as I've gone. I'm working on deployment now, which is a bit more complex than the rest 😅 Should have something RFAL tonight. |
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
Hmm, I don't see why that failed scanning the logs. Let's see if it repros before I spend too long scanning it with a fine toothed comb... /retest |
mattmoor
force-pushed
the
resources-directory
branch
from
741bf22 to
bd158bc
Compare
|
Ok, I think I sorted out the failure. I'd removed a Let's see how this one does. |
|
The following is the coverage report on the affected files.
|
mattmoor
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Generally in Knative our controller structure follows the layout:
This change starts to move things further towards this structure with a new
resources/sub-directory (I did not start anames/sub-directory). I havetried to limit my changes beyond moving code around, but there are a handful
of tweaks I've made, and tests I've added. At this point this new package should
have 100% coverage, which I'll try to preserve as I continue down this path.
/kind cleanup
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes
cc @dibyom @savitaashture