Adds annotation to disable payload validation in eventlistener

[sm43]

This adds an annotation support tekton.dev/payload-validation
for eventlistener. If it is added to el with value as false then
the payload from events will not be validated and will be directly
passed to interceptors.
By default the payload validation is enabled. Only if annotation
is defined and its value is false then it will be disabled
for that particular el.

Closes #1152

Signed-off-by: Shivam Mukhade [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

User can define an annotation on eventlistener tekton.dev/payload-validation: "false" to disable the payload validation in that event listener. By default payload validation is enabled.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.7%	97.8%	0.1
pkg/apis/triggers/v1beta1/event_listener_validation.go	97.7%	97.8%	0.1
pkg/reconciler/eventlistener/eventlistener.go	77.5%	77.2%	-0.3
pkg/sink/validate_payload.go	77.8%	78.9%	1.2

[dibyom]

code looks fine.
quick bike shed on the actual flag name -- disable-payload-validation vs enable-payload-validation (true by default). Or even validate-payload

I think enable-payload-validation: true sounds clearer than disable-payload-validation: false

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.7%	97.8%	0.1
pkg/apis/triggers/v1beta1/event_listener_validation.go	97.7%	97.8%	0.1
pkg/reconciler/eventlistener/eventlistener.go	77.5%	77.2%	-0.3
pkg/sink/validate_payload.go	77.8%	78.9%	1.2

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.7%	97.8%	0.1
pkg/apis/triggers/v1beta1/event_listener_validation.go	97.7%	97.8%	0.1
pkg/reconciler/eventlistener/eventlistener.go	77.5%	77.2%	-0.3
pkg/sink/validate_payload.go	77.8%	78.9%	1.2

[sm43]

/test pull-tekton-triggers-integration-tests

[savitaashture]

code looks fine.
quick bike shed on the actual flag name -- disable-payload-validation vs enable-payload-validation (true by default). Or even validate-payload

I think enable-payload-validation: true sounds clearer than disable-payload-validation: false

yup keeping default value as true enable-payload-validation: true and if user want to disable it they can pass it as false as part of controller.yaml similar to -el-security-context

[sm43]

code looks fine.
quick bike shed on the actual flag name -- disable-payload-validation vs enable-payload-validation (true by default). Or even validate-payload
I think enable-payload-validation: true sounds clearer than disable-payload-validation: false

yup keeping default value as true enable-payload-validation: true and if user want to disable it they can pass it as false as part of controller.yaml similar to -el-security-context

@savitaashture so do you mean to have field in config-defaults to change the default value at controller level?
and annotation would be at eventlistener level to toggle the value?
if we ask users to edit deployment and if it is installed using Operator then this would get overridden,

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.7%	97.7%	0.0
pkg/apis/triggers/v1beta1/event_listener_validation.go	97.7%	97.7%	0.0
pkg/apis/triggers/validation.go	Do not exist	100.0%
pkg/reconciler/eventlistener/eventlistener.go	77.5%	77.3%	-0.3
pkg/sink/validate_payload.go	75.0%	76.2%	1.2

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.7%	97.7%	0.0
pkg/apis/triggers/v1beta1/event_listener_validation.go	97.7%	97.7%	0.0
pkg/apis/triggers/validation.go	Do not exist	100.0%
pkg/reconciler/eventlistener/eventlistener.go	77.5%	77.3%	-0.3
pkg/sink/validate_payload.go	75.0%	76.2%	1.2

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[savitaashture]

/lgtm
Thank you 👍