Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config-defaults configmap to set default values #1182

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

savitaashture
Copy link
Contributor

@savitaashture savitaashture commented Aug 7, 2021

Changes

Adding config-defaults configmap to set default values and as of now serviceAccountName added to config-defaults
Fixes: #682

/cc @dibyom @khrm

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Triggers now support config-defaults configmap to set default values.

@tekton-robot tekton-robot requested review from dibyom and khrm August 7, 2021 06:58
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 7, 2021
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/default.go Do not exist 92.3%
pkg/apis/config/store.go Do not exist 62.5%
pkg/apis/triggers/v1alpha1/event_listener_defaults.go 81.8% 86.7% 4.8

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/default.go Do not exist 92.3%
pkg/apis/config/store.go Do not exist 62.5%
pkg/apis/triggers/v1alpha1/event_listener_defaults.go 81.8% 86.7% 4.8

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/default.go Do not exist 92.3%
pkg/apis/config/store.go Do not exist 62.5%
pkg/apis/triggers/v1alpha1/event_listener_defaults.go 81.8% 86.7% 4.8

Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/reconciler/testing/configmap.go Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2021
@dibyom dibyom mentioned this pull request Aug 9, 2021
4 tasks
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2021
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/default.go Do not exist 92.3%
pkg/apis/config/store.go Do not exist 62.5%
pkg/apis/triggers/v1alpha1/event_listener_defaults.go 81.8% 86.7% 4.8

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/default.go Do not exist 92.3%
pkg/apis/config/store.go Do not exist 62.5%
pkg/apis/triggers/v1alpha1/event_listener_defaults.go 81.8% 86.7% 4.8

Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2021
@tekton-robot tekton-robot merged commit 1a57102 into tektoncd:main Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EventListener ServiceAccountName should default to... default
3 participants