Fix status reconcilation for Knative service

[savitaashture]

Issue:

When we create custom object the READY status of EL always shows false

RootCause:

Polling of Knative service are not done properly and because of that only initial status are set to EL status here

Changes

Added a condition check to set the status to EL when Knative service READY state is True

/cc @dibyom

Effected versions:

Triggers v0.15.0 and v0.15.0-rc1

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/eventlistener/eventlistener.go	78.6%	77.7%	-0.9

[dibyom]

Oh interesting.
Code looks good. Two questions:

1. Do we need a patch release for this?
2. Could we add a test for this behavior?

[savitaashture]

Oh interesting.
Code looks good. Two questions:

1. Do we need a patch release for this?

Yes

2. Could we add a test for this behavior?

For Knative service we are using withPod ducktype and that doesn't have status field to set some dummy value

Lets cover e2e test as part of this issue #1089 so that in future these kind of issues won't miss

[dibyom]

/approve
/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment