Fixes namespac in clusterrolebinding in getting-started #1106
Conversation
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
|
I think this is the same as #1075? My preference would be to only duplicate the ClusterRoleBinding instead of the entire role so that we do not have to keep both in sync when we update RBAC configs. |
@dibyom yep. #1075 will fix the issue. Do you mean we keep existing as it is and create a new yaml to add the required clusterrolebinding? or let #1075 merge with updated readme and close this pr? |
|
yes! |
sm43
force-pushed
the
fix-ns-in-getting-started
branch
from
03c907c to
b40dead
Compare
tekton-robot
added
size/S
sm43
changed the title
|
@dibyom Could you please take a look now? |
|
/test pull-tekton-triggers-integration-tests |
Previously we use to create ClusterRoleBinding with service account in default ns as admin-role.yaml is symbolic link with examples/rbac.yaml, this adds a new clusterrolebinding in docs/getting-started/rbac to update the namespace. Signed-off-by: Shivam Mukhade <[email protected]>
sm43
force-pushed
the
fix-ns-in-getting-started
branch
from
b40dead to
65e85ab
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-triggers-integration-tests |
|
@sm43 it would have been considerate to ask about my progress on this same issue. A shafting, no matter how small is still a shafting. Lol. @dibyom it is quite discouraging to have been in discussion, and come to an agreed upon solution only to find that I have wasted my time. I understand that you probably have a tonne of work, but if you have time or inclination in the future, it may be nicer, especially for newbie developers, if you managed PR clashes with a little more consideration. Edit: so you understand my sentiment I was also pretty stoked to be able to contribute to such a new and cutting edge project. One that I'm sure I will be using for years to come. Thanks both for you work on the project. And perhaps I will be able to contribute some other time. Have a good week ✌️ |
|
@EarthlingDavey Yep. I should have asked you about the status of your PR. Sorry for the mistake :( |
|
Hi, @sm43 thanks for acknowledging :) As I said, I'm sure I'll be using tekton (and k8s) for a long while so I may see you round. |
|
@EarthlingDavey Yikes, totally my bad. I noticed the PR conflict initially but then it slipped my mind when I was approving it. Sorry about that. I appreciate your effort and hope you will still contribute to the project! |
|
@dibyom thanks. On reflection, I should have really commented here when you tagged my PR. It's all good learnings for me. |
Previously we use to create ClusterRoleBinding with service account
in default ns as admin-role.yaml is symbolic link with examples/rbac.yaml,
this adds a new clusterrolebinding in docs/getting-started/rbac to
update the namespace.
Closes #990
Signed-off-by: Shivam Mukhade [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes