-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump CEL version to latest version. #1088
Conversation
The following is the coverage report on the affected files.
|
Interesting, is there an easy way to transform that into a string? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5e70c72
to
4009b53
Compare
Good question, so I added a bit of documentation, and some additional tests to show how to handle this :-) |
@dibyom Ideally we'd deprecate the one in the triggers extension. |
The following is the coverage report on the affected files.
|
That makes sense. We haven't deprecated a CEL function before. What I'm thinking is we add a DEPRECATION NOTICE in the release notes here and update the docs for the triggers extension doc to mention that this function is now deprecated and users should switch to the new CEL function? |
This brings in some bug fixes and adds the upstream CEL base64 encoding and decoding functionality. This is deprecating the triggers decodeb64 function.
4009b53
to
7df5385
Compare
/test pull-tekton-triggers-go-coverage |
1 similar comment
/test pull-tekton-triggers-go-coverage |
The following is the coverage report on the affected files.
|
/lgtm |
Changes
This bumps CEL to v0.7.3, fixes the code to work with the new CEL interfaces, and adds in the CEL Base64 encoding functionality.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes