Resolving build test issues in PRs #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XS
|
@tektoncd/triggers-maintainers this PR just has a single newline and were getting issues with the build tests. im going to change this PR into one that fixes all these issues |
|
Here's my empty line commit build test: https://prow.tekton.dev/log?job=pull-tekton-triggers-build-tests&id=1390512994986758147 |
tekton-robot
added
size/S
jmcshane
changed the title
tekton-robot
added
do-not-merge/work-in-progress
PRs are failing due to gocritic issues. Resolving these.
tekton-robot
added
size/M
tekton-robot
removed
the
do-not-merge/work-in-progress
dibyom
reviewed
May 7, 2021
| @@ -613,7 +613,7 @@ func (r *Reconciler) reconcileCustomObject(ctx context.Context, logger *zap.Suga | |||
| } | |||
| } | |||
|
|
|||
| //if dynamicduck.ReconcileCustomObject(existingCustomObject, data) { | |||
| // if dynamicduck.ReconcileCustomObject(existingCustomObject, data) { | |||
There was a problem hiding this comment.
maybe that's a separate PR...not sure the context behind the comment
|
/kind cleanup |
tekton-robot
added
the
kind/cleanup
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolving small build test issues
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes