Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalization consistency for resourcetemplates #1050

Merged

Conversation

jmcshane
Copy link
Contributor

Changes

Some of the documentation has the wrong capitalization for this spec. We should ensure
the fields are always accurate given the issues mentioned in #526

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Small documentation updates for API consistency

Some of the documentation has the wrong capitalization for this spec. We should ensure
the fields are always accurate given the issues mentioned in tektoncd#526
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 14, 2021
@tekton-robot tekton-robot requested review from khrm and vtereso April 14, 2021 02:39
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 14, 2021
@jmcshane jmcshane changed the title Capitalization consistency for resorucetemplates Capitalization consistency for resourcetemplates Apr 14, 2021
@jmcshane
Copy link
Contributor Author

/assign @iancoffey

@dibyom
Copy link
Member

dibyom commented Apr 14, 2021

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2021
@tekton-robot tekton-robot merged commit 4b9aa31 into tektoncd:main Apr 14, 2021
@jmcshane jmcshane deleted the bugfix/capitalization-consistency branch April 20, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants