Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v1 API for RoleBinding 🦝 #1046

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Apr 12, 2021

Changes

Starting in 1.17, using RoleBinding with
rbac.authorization.k8s.io/v1beta1 is deprecated and will be removed in
1.22. Let's use v1 API instead.

Signed-off-by: Vincent Demeester [email protected]

/cc @tektoncd/triggers-maintainers

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Using `rbac.authorization.k8s.io/v1` instead of `rbac.authorization.k8s.io/v1beta1` for `RoleBinding` as it is being deprecated starting in 1.17.

Starting in 1.17, using `RoleBinding` with
rbac.authorization.k8s.io/v1beta1 is deprecated and will be removed in
1.22. Let's use `v1` API instead.

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot requested a review from a team April 12, 2021 14:29
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 12, 2021
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2021
@tekton-robot tekton-robot merged commit c6ed694 into tektoncd:main Apr 12, 2021
@vdemeester vdemeester deleted the rolebinding-v1 branch April 12, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants