Resolving cache sync issues #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The factory stops syncing based on the context tthat is passed into the Start function. We should wait for the cache sync with the short timeout, but the factory should run for the lifetime of the eventlistener, hence the root context object, with ctx.Done(), as it was before tektoncd#1013
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XS
|
See #1026 for a test case that you can use to reproduce the issue and demonstrate that it is fixed |
|
/assign @ncskier |
|
Hey @jmcshane Thanks for the quick fix 👍 I have verified locally on minikube and its working as expected |
savitaashture
approved these changes
Apr 9, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The factory stops syncing based on the context that is passed into the Start
function. We should wait for the cache sync with the short timeout, but the
factory should run for the lifetime of the eventlistener, hence the root
context object, with ctx.Done(), as it was before #1013
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Release Notes
Closes #1026
Closes #1036