Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update selector RBAC to include ClusterInterceptor #1016

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Update selector RBAC to include ClusterInterceptor #1016

merged 1 commit into from
Mar 24, 2021

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Mar 24, 2021

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 24, 2021
@tekton-robot tekton-robot requested review from dlorenc and wlynch March 24, 2021 16:38
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 24, 2021
@dibyom dibyom mentioned this pull request Mar 24, 2021
Merged
4 tasks
@jmcshane
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2021
@jmcshane
Copy link
Contributor

@dibyom is there a way this could have been caught in the integration tests? just wondering if what @savitaashture experienced should have popped up when the EL starts up

@dibyom
Copy link
Member Author

dibyom commented Mar 24, 2021

#192 might have helped here.

@dibyom dibyom assigned wlynch and unassigned jmcshane Mar 24, 2021
wlynch
wlynch approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2021
@tekton-robot tekton-robot merged commit c31400b into main Mar 24, 2021
@dibyom dibyom deleted the dibyom-patch-1 branch August 6, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlynch wlynch wlynch approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@wlynch wlynch

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dibyom @jmcshane @tekton-robot @wlynch