Interceptors: Implement CRD to provide a single way to install Interceptors #868
Comments
dibyom
added
the
kind/feature
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jan 8, 2021
SYSTEM_NAMESPACE is set to the namespace of the EventListener by the reconciler which means that with the current logic the interceptor url is wrong. Use default namespace to always use `tekton-pipelines` as the namespace. This is hardcoded and the logic is temporary till we implement tektoncd#868.
4 tasks
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jan 8, 2021
SYSTEM_NAMESPACE is set to the namespace of the EventListener by the reconciler which means that with the current logic the interceptor url is wrong. Use default namespace to always use `tekton-pipelines` as the namespace. This is hardcoded and the logic is temporary till we implement tektoncd#868.
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jan 8, 2021
SYSTEM_NAMESPACE is set to the namespace of the EventListener by the reconciler which means that with the current logic the interceptor url is wrong. Use default namespace to always use `tekton-pipelines` as the namespace. This is hardcoded and the logic is temporary till we implement tektoncd#868. Also, actually wire up the HTTP handler in the interceptors server.
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jan 8, 2021
SYSTEM_NAMESPACE is set to the namespace of the EventListener by the reconciler which means that with the current logic the interceptor url is wrong. Use default namespace to always use `tekton-pipelines` as the namespace. This is hardcoded and the logic is temporary till we implement tektoncd#868. Also, actually wire up the HTTP handler in the interceptors server.
tekton-robot
pushed a commit
that referenced
this issue
Jan 11, 2021
SYSTEM_NAMESPACE is set to the namespace of the EventListener by the reconciler which means that with the current logic the interceptor url is wrong. Use default namespace to always use `tekton-pipelines` as the namespace. This is hardcoded and the logic is temporary till we implement #868. Also, actually wire up the HTTP handler in the interceptors server.
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jan 22, 2021
This commit adds the Interceptor CRD type as defined in TEP. The `spec` currently only contains a URL field to locate where the interceptor is running. Other fields will be added as they are implemented in follow ups. Part of tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jan 22, 2021
This commit does the following: 1. Add YAML definitions for each core interceptor using the Interceptor CRD. 2. Modify the EventListener to use the Interceptor CRD to find the Interceptor's URL. 3. Update roles/RBAC/unit tests for the above 2 changes. Fixes tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
4 tasks
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jan 25, 2021
The EventListener did not have knowledge of which namespace Triggers was installed in. Instead it always assumed it was `tekton-pipelines` leading to the bug described in tektoncd#923. This commit fixes this by having the Reconciler send the installation namespace as a environment variable set on the EventListener's pod. NOTE: This fix is temporary and should not be necessary once tektoncd#868 is implemented since then we will resolve the Interceptor's address using information from its CRD. Fixes tektoncd#923 Signed-off-by: Dibyo Mukherjee <[email protected]>
tekton-robot
pushed a commit
that referenced
this issue
Jan 26, 2021
The EventListener did not have knowledge of which namespace Triggers was installed in. Instead it always assumed it was `tekton-pipelines` leading to the bug described in #923. This commit fixes this by having the Reconciler send the installation namespace as a environment variable set on the EventListener's pod. NOTE: This fix is temporary and should not be necessary once #868 is implemented since then we will resolve the Interceptor's address using information from its CRD. Fixes #923 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jan 26, 2021
The EventListener did not have knowledge of which namespace Triggers was installed in. Instead it always assumed it was `tekton-pipelines` leading to the bug described in tektoncd#923. This commit fixes this by having the Reconciler send the installation namespace as a environment variable set on the EventListener's pod. NOTE: This fix is temporary and should not be necessary once tektoncd#868 is implemented since then we will resolve the Interceptor's address using information from its CRD. Fixes tektoncd#923 Signed-off-by: Dibyo Mukherjee <[email protected]>
4 tasks
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jan 26, 2021
This commit adds the Interceptor CRD type as defined in TEP. The `spec` currently only contains a URL field to locate where the interceptor is running. Other fields will be added as they are implemented in follow ups. Part of tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jan 26, 2021
This commit does the following: 1. Add YAML definitions for each core interceptor using the Interceptor CRD. 2. Modify the EventListener to use the Interceptor CRD to find the Interceptor's URL. 3. Update roles/RBAC/unit tests for the above 2 changes. Fixes tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
tekton-robot
pushed a commit
that referenced
this issue
Jan 27, 2021
The EventListener did not have knowledge of which namespace Triggers was installed in. Instead it always assumed it was `tekton-pipelines` leading to the bug described in #923. This commit fixes this by having the Reconciler send the installation namespace as a environment variable set on the EventListener's pod. NOTE: This fix is temporary and should not be necessary once #868 is implemented since then we will resolve the Interceptor's address using information from its CRD. Fixes #923 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jan 28, 2021
This commit does the following: 1. Add YAML definitions for each core interceptor using the Interceptor CRD. 2. Modify the EventListener to use the Interceptor CRD to find the Interceptor's URL. 3. Update roles/RBAC/unit tests for the above 2 changes. Fixes tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jan 28, 2021
This commit does the following: 1. Add YAML definitions for each core interceptor using the Interceptor CRD. 2. Modify the EventListener to use the Interceptor CRD to find the Interceptor's URL. 3. Update roles/RBAC/unit tests for the above 2 changes. Fixes tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jan 29, 2021
This commit does the following: 1. Add YAML definitions for each core interceptor using the Interceptor CRD. 2. Modify the EventListener to use the Interceptor CRD to find the Interceptor's URL. 3. Update roles/RBAC/unit tests for the above 2 changes. Fixes tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 4, 2021
This commit adds the Interceptor CRD type as defined in TEP. The `spec` currently only contains a URL field to locate where the interceptor is running. Other fields will be added as they are implemented in follow ups. Part of tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 4, 2021
This commit does the following: 1. Add YAML definitions for each core interceptor using the Interceptor CRD. 2. Modify the EventListener to use the Interceptor CRD to find the Interceptor's URL. 3. Update roles/RBAC/unit tests for the above 2 changes. Fixes tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 9, 2021
This commit adds the Interceptor CRD type as defined in TEP. The `spec` currently only contains a URL field to locate where the interceptor is running. Other fields will be added as they are implemented in follow ups. Part of tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 9, 2021
This commit does the following: 1. Add YAML definitions for each core interceptor using the Interceptor CRD. 2. Modify the EventListener to use the Interceptor CRD to find the Interceptor's URL. 3. Update roles/RBAC/unit tests for the above 2 changes. Fixes tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 17, 2021
This commit adds a new CRD type called InterceptorType. In TEP-0026 this type was called InterceptorConfig though InterceptorType sounds a bit clearer. The `spec` currently only contains a clientConfig field to locate where the interceptoris running. Other fields will be added as they are implemented in follow ups. This commit also adds a simple reconciler for this type that resolves the clientConfig to a URL and adds it to the `status.address.url` field. Part of tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 18, 2021
This commit adds a new CRD type called InterceptorType. In TEP-0026 this type was called InterceptorConfig though InterceptorType sounds a bit clearer. The `spec` currently only contains a clientConfig field to locate where the interceptor is running. Other fields will be added as they are implemented in follow ups. This commit also adds a simple reconciler for this type that resolves the clientConfig to a URL and adds it to the `status.address.url` field. Part of tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 18, 2021
This commit adds a new CRD type called InterceptorType. In TEP-0026 this type was called InterceptorConfig though InterceptorType sounds a bit clearer. The `spec` currently only contains a clientConfig field to locate where the interceptor is running. Other fields will be added as they are implemented in follow ups. This commit also adds a simple reconciler for this type that resolves the clientConfig to a URL and adds it to the `status.address.url` field. Part of tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 18, 2021
This commit adds a new CRD type called InterceptorType. In TEP-0026 this type was called InterceptorConfig though InterceptorType sounds a bit clearer. The `spec` currently only contains a clientConfig field to locate where the interceptor is running. Other fields will be added as they are implemented in follow ups. This commit also adds a simple reconciler for this type that resolves the clientConfig to a URL and adds it to the `status.address.url` field. Part of tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 18, 2021
This commit does the following: 1. Add YAML definitions for installing each core interceptor using the new InterceptorType CRD. 2. Modify the EventListener to use the InterceptorType CRD to find the Interceptor's URL. Fixes tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 18, 2021
This commit adds a new CRD type called InterceptorType. In TEP-0026 this type was called InterceptorConfig though InterceptorType sounds a bit clearer. The `spec` currently only contains a clientConfig field to locate where the interceptor is running. Other fields will be added as they are implemented in follow ups. This commit also adds a simple reconciler for this type that resolves the clientConfig to a URL and adds it to the `status.address.url` field. Part of tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 18, 2021
This commit adds a new CRD type called InterceptorType. In TEP-0026 this type was called InterceptorConfig though InterceptorType sounds a bit clearer. The `spec` currently only contains a clientConfig field to locate where the interceptor is running. Other fields will be added as they are implemented in follow ups. This commit also adds a simple reconciler for this type that resolves the clientConfig to a URL and adds it to the `status.address.url` field. Part of tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 18, 2021
This commit does the following: 1. Add YAML definitions for installing each core interceptor using the new InterceptorType CRD. 2. Modify the EventListener to use the InterceptorType CRD to find the Interceptor's URL. Fixes tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 19, 2021
This commit adds a new CRD type called InterceptorType. In TEP-0026 this type was called InterceptorConfig though InterceptorType sounds a bit clearer. The `spec` currently only contains a clientConfig field to locate where the interceptor is running. Other fields will be added as they are implemented in follow ups. This commit also adds a simple reconciler for this type that resolves the clientConfig to a URL and adds it to the `status.address.url` field. Part of tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 19, 2021
This commit adds a new CRD type called InterceptorType. In TEP-0026 this type was called InterceptorConfig though InterceptorType sounds a bit clearer. The `spec` currently only contains a clientConfig field to locate where the interceptor is running. Other fields will be added as they are implemented in follow ups. This commit also adds a simple reconciler for this type that resolves the clientConfig to a URL and adds it to the `status.address.url` field. Part of tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 23, 2021
This commit adds a new CRD type called ClusterInterceptorConfiguration. In TEP-0026 this type was called InterceptorConfiguration The `spec` currently only contains a clientConfig field to locate where the interceptor is running. Other fields will be added as they are implemented in follow ups. This commit also adds a simple reconciler for this type that resolves the clientConfig to a URL and adds it to the `status.address.url` field. Part of tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 23, 2021
This commit adds a new CRD type called ClusterInterceptor. In TEP-0026 this type was called InterceptorConfiguration The `spec` currently only contains a clientConfig field to locate where the interceptor is running. Other fields will be added as they are implemented in follow ups. This commit also adds a simple reconciler for this type that resolves the clientConfig to a URL and adds it to the `status.address.url` field. Part of tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 26, 2021
This commit adds a new CRD type called ClusterInterceptor. In TEP-0026 this type was called InterceptorConfiguration The `spec` currently only contains a clientConfig field to locate where the interceptor is running. Other fields will be added as they are implemented in follow ups. This commit also adds a simple reconciler for this type that resolves the clientConfig to a URL and adds it to the `status.address.url` field. Part of tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Feb 26, 2021
This commit does the following: 1. Add YAML definitions for installing each core interceptor using the new InterceptorType CRD. 2. Modify the EventListener to use the InterceptorType CRD to find the Interceptor's URL. Fixes tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
4 tasks
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Mar 4, 2021
This commit adds a new CRD type called ClusterInterceptor. In TEP-0026 this type was called InterceptorConfiguration The `spec` currently only contains a clientConfig field to locate where the interceptor is running. Other fields will be added as they are implemented in follow ups. This commit also adds a simple reconciler for this type that resolves the clientConfig to a URL and adds it to the `status.address.url` field. Part of tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Mar 4, 2021
This commit does the following: 1. Add YAML definitions for installing each core interceptor using the new InterceptorType CRD. 2. Modify the EventListener to use the InterceptorType CRD to find the Interceptor's URL. Fixes tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Mar 9, 2021
This commit adds a new CRD type called ClusterInterceptor. In TEP-0026 this type was called InterceptorConfiguration The `spec` currently only contains a clientConfig field to locate where the interceptor is running. Other fields will be added as they are implemented in follow ups. This commit also adds a simple reconciler for this type that resolves the clientConfig to a URL and adds it to the `status.address.url` field. Part of tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Mar 9, 2021
This commit does the following: 1. Add YAML definitions for installing each core interceptor using the new InterceptorType CRD. 2. Modify the EventListener to use the InterceptorType CRD to find the Interceptor's URL. Fixes tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Mar 11, 2021
This commit adds a new CRD type called ClusterInterceptor. In TEP-0026 this type was called InterceptorConfiguration The `spec` currently only contains a clientConfig field to locate where the interceptor is running. Other fields will be added as they are implemented in follow ups. This commit also adds a simple reconciler for this type that resolves the clientConfig to a URL and adds it to the `status.address.url` field. Part of tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
tekton-robot
pushed a commit
that referenced
this issue
Mar 11, 2021
This commit adds a new CRD type called ClusterInterceptor. In TEP-0026 this type was called InterceptorConfiguration The `spec` currently only contains a clientConfig field to locate where the interceptor is running. Other fields will be added as they are implemented in follow ups. This commit also adds a simple reconciler for this type that resolves the clientConfig to a URL and adds it to the `status.address.url` field. Part of #868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Mar 11, 2021
This commit does the following: 1. Add YAML definitions for installing each core interceptor using the new InterceptorType CRD. 2. Modify the EventListener to use the InterceptorType CRD to find the Interceptor's URL. Fixes tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Mar 15, 2021
This commit does the following: 1. Add YAML definitions for installing each core interceptor using the new InterceptorType CRD. 2. Modify the EventListener to use the InterceptorType CRD to find the Interceptor's URL. Fixes tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Mar 16, 2021
This commit does the following: 1. Add YAML definitions for installing each core interceptor using the new InterceptorType CRD. 2. Modify the EventListener to use the InterceptorType CRD to find the Interceptor's URL. Fixes tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Mar 16, 2021
This commit does the following: 1. Add YAML definitions for installing each core interceptor using the new InterceptorType CRD. 2. Modify the EventListener to use the InterceptorType CRD to find the Interceptor's URL. Fixes tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Mar 16, 2021
This commit does the following: 1. Add YAML definitions for installing each core interceptor using the new InterceptorType CRD. 2. Modify the EventListener to use the InterceptorType CRD to find the Interceptor's URL. Fixes tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
tekton-robot
pushed a commit
that referenced
this issue
Mar 18, 2021
This commit does the following: 1. Add YAML definitions for installing each core interceptor using the new InterceptorType CRD. 2. Modify the EventListener to use the InterceptorType CRD to find the Interceptor's URL. Fixes #868 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Mar 18, 2021
This commit does the following: 1. Add YAML definitions for installing each core interceptor using the new InterceptorType CRD. 2. Modify the EventListener to use the InterceptorType CRD to find the Interceptor's URL. Fixes tektoncd#868 Signed-off-by: Dibyo Mukherjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The work for this will involve implementing the InterceptorConfig CRD as described in TEP-0026
The text was updated successfully, but these errors were encountered: