Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook: TLS handshake error from 10.128.0.8:47288: secret "triggers-webhook-certs" not found #803

Closed
dibyom opened this issue Oct 15, 2020 · 2 comments · Fixed by #804
Closed

Webhook: TLS handshake error from 10.128.0.8:47288: secret "triggers-webhook-certs" not found #803

dibyom opened this issue Oct 15, 2020 · 2 comments · Fixed by #804
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
Triggers v0.9.1

Comments

@dibyom
Copy link
Member

dibyom commented Oct 15, 2020

Expected Behavior

Users in fresh Triggers installation can create new triggers resources

Actual Behavior

Users in new triggers installs cannot create new triggers resources.
Triggers webhook logs if filled with:

TLS handshake error from 10.128.0.8:47288: secret "triggers-webhook-certs" not found

Additional Info

  1. I think this only happens for new clusters where Triggers was not installed before and not if one is upgrading.

/kind bug
@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 15, 2020
@dibyom dibyom added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Oct 15, 2020
@dibyom
Copy link
Member Author

dibyom commented Oct 15, 2020

Probably related to: 8eb2067

@dibyom
Copy link
Member Author

dibyom commented Oct 15, 2020

Strange this has not failed e2e tests since they run in fresh cluster?

dibyom added a commit to dibyom/triggers that referenced this issue Oct 15, 2020
@dibyom
Revert "dibyo's point about only EL sink/interceptors reading secrets"
650b134 
This reverts commit 8eb2067.

Turns out, the webhook does need access to create secrets since it uses it
to create `tekton-webhook-certs` if it does not exist.

Fixes tektoncd#803
@dibyom dibyom mentioned this issue Oct 15, 2020
Merged
4 tasks
@dibyom dibyom added this to the Triggers v0.9.1 milestone Oct 15, 2020
tekton-robot pushed a commit that referenced this issue Oct 15, 2020
@dibyom @tekton-robot
Revert "dibyo's point about only EL sink/interceptors reading secrets"
397d151 
This reverts commit 8eb2067.

Turns out, the webhook does need access to create secrets since it uses it
to create `tekton-webhook-certs` if it does not exist.

Fixes #803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
Triggers v0.9.1
Development

Successfully merging a pull request may close this issue.

Revert "dibyo's point about only EL sink/interceptors reading secrets" dibyom/triggers
2 participants
@dibyom @tekton-robot