Find root cause for why reconciler tests were not failing

[dibyom]

Expected Behavior

Reconciler tests should fail when expected test output does not match actual output.

Actual Behavior

Our reconciler tests were passing when expected test output did not match actual output 😱 😱

While working on #1244 I noticed that our reconciler tests were ignoring metav1.ObjectMeta.Finalizers for test output comparison. I decided to remove that line since we are no longer using Finalizers since #1207

On removing that line though, I noticed a bunch of our tests started failing. Specifically the expected container args field in the deployment did not match the actual container args in the deployment. I verified that the actual container args were correct and that the expected values in the test were wrong. We did not update the tests when we moved the args field from -foo, value to the --foo=value pattern.

I fixed the tests but did not investigate the root cause.

We should find out why our unit tests were wrong i.e not comparing the values correctly.

[dibyom]

@wlynch @lbernick and I were looking into this. We found that the main cause was the ignore function we were using.

We were using cmpopts.IgnoreTypes which "ignores all values assignable to certain types, which are specified by passing in a value of each type."

ObjectMeta.Finalizers has type []string which meant that the test was ignore all []string types in comparison (like the container args) field.

To fix, we should move to cmpopts.IgnoreFields which ignores a given field within a specific struct type.

@wlynch also found that we were using IgnoreTypes in a bunch of pipelines tests too for ignoring the LastTransitionTime field in status.Conditions. We should fix that too.