Make the main releases multi-arch

[afrittoli]

Changes

With multi-arch builds, the base image is built by a dedicated
task and should not be in the list of outputs of the publish
task. Since the publish task is shared by nightly and full
releases, the solution is to turn the full releases to multi
arch as well.

Signed-off-by: Andrea Frittoli [email protected]
/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Tekton full releases will be multi-arch as well

[afrittoli]

/cc @barthy1 @vdemeester

[vdemeester]

Where is this defined ? 😅

[barthy1]

https://github.com/tektoncd/pipeline/blob/master/tekton/build-push-ma-base-image.yaml#L4

[vdemeester]

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[barthy1]

/lgtm

[pritidesai]

@afrittoli do I need to update pipeline pipeline-release so that these changes show up in the dogfooding cluster?

kubectl get pipeline pipeline-release -o json | jq .spec.tasks[].name
"precheck"
"unit-tests"
"build"
"publish-images"

It's missing build-base-image task which was introduced in this PR.

Please bear with me while I am trying to make sure the release runs smooth without any hiccups 🙏

[afrittoli]

Yes, this needs to be updated on the cluster, good catch.
Once OCI is stable enough we can make one bundle per repo and consume these tasks and pipelines via OCI :)

[pritidesai]

How do we apply such updates on dogfooding cluster? run kubectl apply -f tekton/release-pipeline.yaml?