This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postcss did this as well, so we have to follow them.
lowiebenoot
force-pushed
the
upgrade-postcss-8
branch
from
December 8, 2020 10:06
34c24f6
to
ae86f3e
Compare
lowiebenoot
requested review from
ArnaudWeyts,
lorgan3,
driesd,
EOSullivanBerlin,
timdegroote and
mikeverf
December 8, 2020 10:06
lorgan3
approved these changes
Dec 8, 2020
timdegroote
approved these changes
Dec 8, 2020
driesd
approved these changes
Dec 8, 2020
⌛ Manually checking |
EOSullivanBerlin
approved these changes
Dec 8, 2020
✅ Manually checked |
Shouldn't postcss-cli also be upgraded to 8? I guess it works without upgrading 🤔 I guess we'll also have to upgrade a lot of plugins, since those seem to require adding "support" for postcss 8 F.e: |
I'll just update them all in one go 👍 |
Upgraded all postcss plugins (that had updates). |
This was referenced Dec 9, 2020
lorgan3
approved these changes
Dec 9, 2020
timdegroote
approved these changes
Dec 9, 2020
ArnaudWeyts
approved these changes
Dec 9, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrading to postcss 8.
Breaking changes