Fix js animation not disable if load jquery in body #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalpole
requested changes
Jan 22, 2021
spec/shared_selenium_session.rb
Outdated
| @@ -405,7 +405,9 @@ | |||
| @animation_session.visit('with_animation') | |||
| scroll_y = @animation_session.evaluate_script(<<~JS) | |||
| (function(){ | |||
| window.scrollTo(0,500); | |||
| $('html, body').animate({ | |||
There was a problem hiding this comment.
@why are you modifying this test? If you want to test different behavior add a new test.
| @@ -77,6 +63,20 @@ | |||
| <a href='#' class='animation' onclick='this.classList.add("away")' oncontextmenu='this.classList.add("pseudo")'> | |||
| animate me away | |||
| </a> | |||
| <script src="/jquery.js" type="text/javascript" charset="utf-8"></script> | |||
There was a problem hiding this comment.
If a new view is needed for new tests please create it rather than modifying the existing one.
kuei0221
force-pushed
the
fix/js_animation_not_disable_if_load_jquery_in_body
branch
from
58129e0 to
f95e581
Compare
|
LGTM - thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animation disabler now can only turn off the animation come from jQuery if jQuery is loaded in head, because
insert_disableplace the template at the end of head.capybara/lib/capybara/server/animation_disabler.rb
Lines 42 to 44 in a08e047
If jQuery is loaded with the body, jQuery will be undefined in head so the function won't work.
capybara/lib/capybara/server/animation_disabler.rb
Lines 46 to 49 in a08e047
By placing it to the end of the body, developer do not have to worry about where they are loading jQuery and give a better experience 😄