Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eslint-plugin-jest v24 #219

Merged
merged 3 commits into from
Sep 5, 2020
Merged

Support eslint-plugin-jest v24 #219

merged 3 commits into from
Sep 5, 2020

Conversation

pohnemus
Copy link
Collaborator

@pohnemus pohnemus commented Sep 5, 2020

There was a breaking change that impacted our ruleset (no-test-callback: rename no-test-callback to no-done-callback) in eslint-plugin-jest v24. This makes that change as well as:

  • Adds the other new "recommended" rules from v24 (why don't we just use their recommendations?)
  • Sets the peerDependencies properly - issue from last release
  • Bumps our version to v15

@tclindner
Copy link
Owner

  • Adds the other new "recommended" rules from v24 (why don't we just use their recommendations?)

Right now we do everything in overrides, which don't support extends. We can add the jest rules so they apply to all files. What do you think?

@tclindner tclindner merged commit 597d8da into master Sep 5, 2020
@tclindner tclindner deleted the v15 branch September 5, 2020 19:05
@pohnemus
Copy link
Collaborator Author

pohnemus commented Sep 5, 2020

  • Adds the other new "recommended" rules from v24 (why don't we just use their recommendations?)

Right now we do everything in overrides, which don't support extends. We can add the jest rules so they apply to all files. What do you think?

Yea that's fine. Just seems like unnecessary maintenance.

@tclindner
Copy link
Owner

Sorry, not tracking your answer. Would you like to switch and have all of the jest rules apply to all files? I'm okay doing that. I would also like to get rid of the Jest global since Jest is trying to work in the direction over the next couple of major versions.

@pohnemus
Copy link
Collaborator Author

pohnemus commented Sep 5, 2020

Sorry, not tracking your answer. Would you like to switch and have all of the jest rules apply to all files? I'm okay doing that. I would also like to get rid of the Jest global since Jest is trying to work in the direction over the next couple of major versions.

Ah sorry, I didn't follow your question :). I didn't realize this would require us to run against all files. I would like to get as close to the default / suggested approach as possible - whatever that is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants