Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding jest/prefer-called-with #89

Closed
tclindner opened this issue Oct 29, 2019 · 1 comment · Fixed by #105
Closed

Consider adding jest/prefer-called-with #89

tclindner opened this issue Oct 29, 2019 · 1 comment · Fixed by #105
Labels
enhancement 👑 New feature or request
Milestone
v10.0.0

Comments

@tclindner
Copy link
Owner

https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/prefer-called-with.md
@phil-rw
Copy link
Contributor

phil-rw commented Oct 30, 2019

I like this, but I'm nervous on how many changes this is going to introduce in our code base.

@tclindner tclindner added the enhancement 👑 New feature or request label Nov 2, 2019
@tclindner tclindner added this to the v10.0.0 milestone Nov 2, 2019
phil-rw pushed a commit to phil-rw/eslint-config-tc that referenced this issue Dec 1, 2019
jest additions
eb83aea 
Adds agreed upon Jest additions:
* closes tclindner#90 - jest/expect-expect
* closes tclindner#89 - jest/prefer-called-with
* closes tclindner#87 - jest/prefer-hooks-on-top
* closes tclindner#85 - jest/require-top-level-describe
@phil-rw phil-rw mentioned this issue Dec 1, 2019
Merged
tclindner pushed a commit that referenced this issue Dec 5, 2019
@phil-rw @tclindner
jest additions (#105)
7d2086e 
Adds agreed upon Jest additions:
* closes #90 - jest/expect-expect
* closes #89 - jest/prefer-called-with
* closes #87 - jest/prefer-hooks-on-top
* closes #85 - jest/require-top-level-describe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 👑 New feature or request
Projects
None yet
Milestone
v10.0.0
Development

Successfully merging a pull request may close this issue.

Jest additions phil-rw/eslint-config-tc
2 participants
@tclindner @phil-rw