Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider tweaking the import/no-extraneous-dependencies rule #255

Closed
pohnemus opened this issue Nov 11, 2020 · 0 comments · Fixed by #262
Closed

Consider tweaking the import/no-extraneous-dependencies rule #255

pohnemus opened this issue Nov 11, 2020 · 0 comments · Fixed by #262
Assignees
@tclindner

Comments

@pohnemus
Copy link
Collaborator

Not sure we should do this, but I've seen a few repos doing it and it seems like it might be valuable for us. Would need to tweak the extension.

'import/no-extraneous-dependencies': ['error', {devDependencies: ['**/test/*.ts'], peerDependencies: false}],
@pohnemus pohnemus added this to the v17.0.0 milestone Nov 14, 2020
tclindner added a commit that referenced this issue Dec 6, 2020
@tclindner
Update import/no-extraneous-dependencies config
5d0b65b 
Closes #255
@tclindner tclindner mentioned this issue Dec 6, 2020
Merged
@tclindner tclindner removed this from the v17.0.0 milestone Dec 6, 2020
@tclindner tclindner self-assigned this Dec 6, 2020
pohnemus pushed a commit that referenced this issue Dec 6, 2020
@tclindner
16.3.0 (#262)
ee8250d 
* Ignore no-undefined in tests

* Bump eslint

* Bump version

* Update peerDeps range for eslint-plugin-jest

* Update import/no-extraneous-dependencies config

Closes #255

* Turn off import/prefer-default-export

* Update file patterns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tclindner tclindner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

16.3.0 tclindner/eslint-config-tc
2 participants
@pohnemus @tclindner