Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/external #961

Merged
merged 1 commit into from
Dec 20, 2021
Merged

fix/external #961

merged 1 commit into from
Dec 20, 2021

Conversation

tchiotludo
Copy link
Owner

  • Test for RestApiClaimProvider
  • Disable KafkaWrapperFilter which interracts incorrectly with RestApiExternalService Controller
  • wip

@tchiotludo tchiotludo mentioned this pull request Dec 20, 2021
Closed
3 tasks
@tchiotludo tchiotludo force-pushed the fix/external branch 3 times, most recently from 777914b to 25bbf9a Compare December 20, 2021 09:23
twobeeb
twobeeb approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@twobeeb twobeeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it looks better this way.
I think I originally wanted to leave room for evolution by keeping Map<String, Object> attributes but now I think it's better to strong-type everything.

@tchiotludo tchiotludo merged commit 01d2eef into dev Dec 20, 2021
@tchiotludo tchiotludo deleted the fix/external branch December 20, 2021 20:41
@loicgreffier loicgreffier mentioned this pull request Feb 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twobeeb twobeeb twobeeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchiotludo @twobeeb