Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm): Use toYaml Go template for configmap #746

Merged
merged 4 commits into from
Jun 29, 2021
Merged

fix(helm): Use toYaml Go template for configmap #746

merged 4 commits into from
Jun 29, 2021

Conversation

AnatomicJC
Copy link
Contributor

No description provided.

@tchiotludo
Copy link
Owner

agree with that :)
It wil be better but we need to be consistent, can you make the change everywhere (secrets, ...) ?

@AnatomicJC
Copy link
Contributor Author

Hi @tchiotludo

I updated the values.yaml file accordingly.

I also replaced indent with nindent. Do you see other things to update ?

@tchiotludo
Copy link
Owner

configuration is also yml and can't be use as yaml in values

@AnatomicJC
Copy link
Contributor Author

I reverted my last commit about indent and nindent
I tested on a local cluster and configmap seems ok now. What do you think ?

@tchiotludo
Copy link
Owner

perfect, thanks :)

@tchiotludo tchiotludo merged commit 2bd7222 into tchiotludo:dev Jun 29, 2021
@AnatomicJC
Copy link
Contributor Author

Thanks to you for this project 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnatomicJC @tchiotludo