Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): log login failures #699

Merged
merged 1 commit into from
May 15, 2021

Conversation

gquintana
Copy link
Contributor

Try to implement #697

The result is log saying:

2021-05-13 22:03:17,607 WARN  pGroup-1-3 u.LoginFailedEventListener Login failed reason USER_NOT_FOUND, username unknown, message User Not Found
2021-05-13 22:04:39,488 WARN  pGroup-1-4 u.LoginFailedEventListener Login failed reason CREDENTIALS_DO_NOT_MATCH, username unknown, message Credentials Do Not Match

Which is not very satisfactory, because the username is always unknown.

The AuthenticationFailed class contains:

    @Override
    public Optional<UserDetails> getUserDetails() {
        return Optional.empty();
    }

So I think it requires a change in Micronaut in AuthenticationFailed and in various AuthenticationProviders

@gquintana gquintana force-pushed the feat/log-login-failed branch from 430322e to a9a5e54 Compare May 13, 2021 20:09
@gquintana gquintana force-pushed the feat/log-login-failed branch from a9a5e54 to 6e6358a Compare May 13, 2021 20:10
@gquintana
Copy link
Contributor Author

Build fails due to SchemaControllerTest#listApi test which also fails on dev branch

@tchiotludo tchiotludo merged commit f691db0 into tchiotludo:dev May 15, 2021
twobeeb pushed a commit to twobeeb/akhq that referenced this pull request May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants