Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled login button if security is not enabled #532

Merged
merged 2 commits into from
Dec 22, 2020
Merged

Disabled login button if security is not enabled #532

merged 2 commits into from
Dec 22, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 4, 2020

Fix #507

Changed call to auths api to Routes.js.
Put result on session storage.
Use the storage data in Login Page and Header to enable login.

@ghost ghost requested a review from tchiotludo December 4, 2020 15:16
@tchiotludo
Copy link
Owner

I have some compilation errors here :

Failed to compile.

./src/utils/Routes.js
  Line 28:48:  'uriTopicDataSingleRecord' is defined but never used  no-unused-vars
  Line 28:74:  'uriTopicsPartitions' is defined but never used       no-unused-vars

./src/containers/Login/Login.jsx
  Line 4:9:  'uriAuths' is defined but never used  no-unused-vars

@ghost
Copy link
Author

ghost commented Dec 9, 2020

Removed unused imports

@tchiotludo tchiotludo merged commit c9aef71 into dev Dec 22, 2020
@tchiotludo tchiotludo deleted the feat/507_Disabledloginbuttonifsecurityisnotenabled branch December 22, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchiotludo tchiotludo Awaiting requested review from tchiotludo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disabled login button if security is not enabled
1 participant
@tchiotludo