-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to React 18 #1678
Upgrade to React 18 #1678
Conversation
@tchiotludo to follow the frontend dependencies upgrade PR. I didn't start to rewrite everything to functional components. I preferred an intermediate approach by recreating withRouter (as explained here that uses the hooks) |
Fixing CSS and navigation Fixing connect and ksqldb Fixing tail styles
cff4632
to
dd51d28
Compare
* Initial commit * Fixing CSS and navigation * Fixing connect and ksqldb * Routing reworked * Treating topic-route the same as /data * Removing branch-tag from sidebar when collapsing --------- Co-authored-by: AlexisSouquiere <[email protected]> Co-authored-by: AlexisSouquiere <[email protected]> Co-authored-by: Jonas Voelcker <[email protected]>
Fixing ACL styles
Updating package-lock.json Prettier and Linting
497f98a
to
3a6cd56
Compare
Hi @tchiotludo, I think we are in a state where some feedback would be really good to proceed. I don't have the clusters or knowhow to see every single page and feature but I guess the basics have been done :) Those are the main changes I think we made:
FYI: @AlexisSouquiere |
I will install this version on our DEV cluster next week to get some feedback and see if we missed anything. |
@jonasvoelcker @AlexisSouquiere thanks for the amazing work so far. Is there any blocker on your side so far? |
Hey @tchiotludo, from what I tested with our cluster we do not have blockers yet but there should be a good amount of testing by different people which @AlexisSouquiere starts next week in his company I guess. Sometimes there were some weird behaviors in the routing and the "newest"-search should undergo some heavy rework at some time, but I think this topic shouldn't block the release and take place in another pull request. If you could make some checks in parallel to Alexis I would be really greatful for that, currently I have some time left for this but after next week this will decrease drastically I guess. One last thought: Vite mentions that the component's render-behavior is not quite right and it hinders the hot reload to take place. As the tool seems to work well in production mode I didn't invest time in fixing the component's composition as this would mean a massive amount of time to implement a new concept for that. |
Apply primary color on pagination Standardize lighten/darken on hover Remove white class on Tail dropdowns
@tchiotludo as Jonas said, I just deployed this branch on one of our instance to get feedback from other users. |
@tchiotludo PR is ready for me. I think that after merging we can let people trying it on the dev branch for a week or two before releasing but I didn't had any complains on my side with this new version. cc @jonasvoelcker. Thanks again for your work and help on this one. You did the biggest parts 👏 |
quick try in my side, seems to be working, congrats for the huge amount of work! |
TODO: