Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Enterprise / SSO #1606

Closed
kanimaru opened this issue Oct 27, 2023 · 2 comments
Closed

Github Enterprise / SSO #1606

kanimaru opened this issue Oct 27, 2023 · 2 comments

Comments

@kanimaru
Copy link

Hi the #990 isn't done correctly the requester asked for Github Enterprise but the implementation referenced in the issue #1319 only works for github.com I think it has to be changed just a little to work with GHE also.

The fix path in the https://github.com/tchiotludo/akhq/blob/dev/src/main/java/org/akhq/security/authentication/GithubApiClient.java#L11 needs to be configureable. But I'm not confident enough in micronaut to do it.

@Client("https://api.github.com")
public interface GithubApiClient {
@JeniaTr
Copy link

JeniaTr commented Nov 17, 2023

image
image
I also have a problem with access from the organization when using GitHub SSO
Nothing helps. As far as I understand, this functionality is not ready yet

@tchiotludo
Copy link
Owner

done in #1613

@github-project-automation github-project-automation bot moved this from Backlog to Done in Backlog Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants