Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade/element-web v1.11.17 : fix linter #383

Merged

Conversation

estellecomment
Copy link
Contributor

@estellecomment estellecomment commented Jan 20, 2023

Fixes the CI for "Static Analysis", "ESLint". Changes were made in element-web 1.11.17 which broke it.

  • prettier is used as a formatter. It uses eslint's config in this case. It does not have a warning mode, so it errors on our files. I disabled it.
  • eslint wants a standard version number. So we use 4.1.5-1.11.17 instead of 4.1.5_1.11.17. We have to watch out for deployment script breaks.
  • our code does not follow all the new style rules that were added. So for our code, I replaced errors with warnings, until we have them all fixed. We can fix them as we go when we edit the files.
  • we are also linting module_system which is not our files. So I removed it.

Note : things would be simpler if all tchap code was in a single directory, so that we would only lint our own files. Also nice for devs to understand which code is which.

@gitguardian
Copy link

gitguardian bot commented Jan 20, 2023

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@estellecomment estellecomment changed the base branch from develop_tchap to upgrade/element-web-v1.11.17 January 20, 2023 10:43
@estellecomment estellecomment changed the title Upgrade/element web v1.11.17 fix linter Upgrade/element-web v1.11.17 : fix linter Jan 20, 2023
@estellecomment estellecomment marked this pull request as ready for review January 20, 2023 11:00
@odelcroi odelcroi self-requested a review January 20, 2023 12:03
@odelcroi odelcroi closed this Jan 20, 2023
@odelcroi odelcroi reopened this Jan 20, 2023
@odelcroi odelcroi merged commit 2e255ea into upgrade/element-web-v1.11.17 Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants