Reduce locale dependence in non-iso-calendars.js #4048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The performance logging was left over from when this test lived in the proposal-temporal repo. It was already switched off anyway.
Ms2ger
reviewed
Apr 10, 2024
ptomato
force-pushed
the
locale-dependent-calendar-formatting
branch
from
8a2765f to
be809b8
Compare
ptomato
force-pushed
the
locale-dependent-calendar-formatting
branch
from
be809b8 to
550028e
Compare
Previously, this test checked for a particular format. This would break depending on which engine executed it. Instead, test for the presence of particular types and their values in the output of formatToParts(). (There's an existing comment which suggests that this should already have been testing formatToParts().)
Using Object.keys() of the expected values in each case decouples these tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a staging test that was tightly coupled to particular 'golden' output from toLocaleString. Rewrite it so that it uses formatToParts instead, and tests for the presence of particular parts, and their values.
Also removes some dead logging code from this test file.