Normative: Disallow rounding to increment while balancing to calendar unit #2916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Jul 15, 2024
This test covers a normative change to disallow an ambiguous corner case in the options bag for Temporal.Duration.prototype.round(). See tc39/proposal-temporal#2916
|
Draft until presented to TC39. |
|
Test262 update in tc39/test262#4152. Note tests are currently passing on this PR because this case just wasn't covered. |
91 tasks
|
Achieved consensus at TC39 plenary 2024-07-30. |
… unit
The corner case of rounding to a >1 increment of a calendar smallest unit
while simultaneously balancing to a larger calendar unit is ambiguous.
This use case was probably never considered.
const d1 = Temporal.Duration.from({months: 9});
d1.round({
relativeTo: '2024-01-01',
largestUnit: 'years',
smallestUnit: 'months',
roundingIncrement: 8,
roundingMode: 'ceil',
}); // => 1 year? 1 year 4 months?
This never came up in real-world usage. Disallow it explicitly, to leave
space for a future proposal if it ever comes up.
Closes: #2902
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Sep 5, 2024
This test covers a normative change to disallow an ambiguous corner case in the options bag for Temporal.Duration.prototype.round(). See tc39/proposal-temporal#2916
ptomato
added a commit
to tc39/test262
that referenced
this pull request
Sep 5, 2024
This test covers a normative change to disallow an ambiguous corner case in the options bag for Temporal.Duration.prototype.round(). See tc39/proposal-temporal#2916
ptomato
force-pushed
the
2902-disallow-calendar-rounding-increment
branch
from
3796b9b to
6f175b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corner case of rounding to a >1 increment of a calendar smallest unit while simultaneously balancing to a larger calendar unit is ambiguous. This use case was probably never considered.
This never came up in real-world usage. Disallow it explicitly, to leave space for a future proposal if it ever comes up.
Closes: #2902