Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Collapse nonterminals only used for disambiguation #2767

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

ptomato
Copy link
Collaborator

@ptomato ptomato commented Feb 2, 2024

Prefer language like "the first |TemporalDecimalFraction|, if present" rather than defining several nonterminals such as |TimeFraction|, |DurationHoursFraction|, etc.

Closes: #2006

@ptomato ptomato requested a review from gibson042 February 2, 2024 17:51
@ptomato ptomato mentioned this pull request Feb 2, 2024
91 tasks
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.57%. Comparing base (82ad54f) to head (d9d1722).
Report is 12 commits behind head on main.

Current head d9d1722 differs from pull request most recent head 3765bf6

Please upload reports for the commit 3765bf6 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2767      +/-   ##
==========================================
+ Coverage   96.51%   96.57%   +0.06%     
==========================================
  Files          23       23              
  Lines       12432    12243     -189     
  Branches     2258     2268      +10     
==========================================
- Hits        11999    11824     -175     
+ Misses        374      358      -16     
- Partials       59       61       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed (in person!). I'm hoping to recover the simplicity of ParseTemporalDurationString via something like #2290, but that would build on top of this anyway. :shipit:

Prefer language like "the first |TemporalDecimalFraction|, if present"
rather than defining several nonterminals such as |TimeFraction|,
|DurationHoursFraction|, etc.

Closes: #2006
@ptomato ptomato force-pushed the 2006-collapse-nonterminals branch from d9d1722 to 3765bf6 Compare June 13, 2024 19:55
@ptomato
Copy link
Collaborator Author

ptomato commented Jun 13, 2024

@gibson042 Thanks for finding the time to review these in person!

@ptomato ptomato merged commit 0b6d1c1 into main Jun 13, 2024
5 checks passed
@ptomato ptomato deleted the 2006-collapse-nonterminals branch June 13, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapse grammar nonterminals that are only distinct for the purposes of disambiguation
2 participants