Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ISO Date, ISO Date-Time, and Time Records in more places in the polyfill #3005

Closed
Ms2ger opened this issue Oct 8, 2024 · 0 comments · Fixed by #3006
Closed

Use ISO Date, ISO Date-Time, and Time Records in more places in the polyfill #3005

Ms2ger opened this issue Oct 8, 2024 · 0 comments · Fixed by #3006
Assignees
@ptomato
Labels
editorial non-prod-polyfill THIS POLYFILL IS NOT FOR PRODUCTION USE! spec-text Specification text involved

Comments

@Ms2ger
Copy link
Collaborator

Ms2ger commented Oct 8, 2024

See the comments from Justin in #3003.
@ptomato ptomato mentioned this issue Oct 8, 2024
Merged
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Abstract days range check into CheckISODaysRange
4fdf028 
This pattern is there because of #2729 and #2985. Abstract it into its own
operation, for documentation purposes and because it can disappear after
tc39/ecma262#1087 is fixed.

See: #3005
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Polyfill: Refactor GetUTCEpochMilliseconds to use ISO Date-Time Record
02b5039 
This operation doesn't exist in the spec text, it's just an optimization
to make the tests run faster.

See: #3005
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Polyfill: Use object spreading for readability
93231d2 
See: #3005
@ptomato ptomato mentioned this issue Oct 8, 2024
Merged
@ptomato ptomato self-assigned this Oct 8, 2024
@ptomato ptomato added spec-text Specification text involved editorial non-prod-polyfill THIS POLYFILL IS NOT FOR PRODUCTION USE! labels Oct 8, 2024
ptomato added a commit that referenced this issue Oct 9, 2024
@ptomato
Editorial: Abstract days range check into CheckISODaysRange
14e85b6 
This pattern is there because of #2729 and #2985. Abstract it into its own
operation, for documentation purposes and because it can disappear after
tc39/ecma262#1087 is fixed.

See: #3005
ptomato added a commit that referenced this issue Oct 9, 2024
@ptomato
Polyfill: Refactor GetUTCEpochMilliseconds to use ISO Date-Time Record
348c12f 
This operation doesn't exist in the spec text, it's just an optimization
to make the tests run faster.

See: #3005
ptomato added a commit that referenced this issue Oct 9, 2024
@ptomato
Polyfill: Use object spreading for readability
848634b 
See: #3005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptomato ptomato

Labels
editorial non-prod-polyfill THIS POLYFILL IS NOT FOR PRODUCTION USE! spec-text Specification text involved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editorial: Follow up suggestions from Justin tc39/proposal-temporal
2 participants
@Ms2ger @ptomato