Fix division issues caught by tsc in RoundDuration

Port of js-temporal/temporal-polyfill#14
tc39 · Jul 16, 2021 · 4b4dbd4 · 4b4dbd4
1 parent 88bad4d
commit 4b4dbd4
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/polyfill/lib/ecmascript.mjs b/polyfill/lib/ecmascript.mjs
@@ -3900,8 +3900,8 @@ export const ES = ObjectAssign({}, ES2020, {
         oneYearDays = MathAbs(oneYearDays);
         const divisor = bigInt(oneYearDays).multiply(dayLengthNs);
         nanoseconds = divisor.multiply(years).plus(bigInt(days).multiply(dayLengthNs)).plus(nanoseconds);
-        const rounded = ES.RoundNumberToIncrement(nanoseconds, divisor * increment, roundingMode);
-        total = nanoseconds.toJSNumber() / divisor;
+        const rounded = ES.RoundNumberToIncrement(nanoseconds, divisor.multiply(increment).toJSNumber(), roundingMode);
+        total = nanoseconds.toJSNumber() / divisor.toJSNumber();
         years = rounded.divide(divisor).toJSNumber();
         nanoseconds = months = weeks = days = 0;
         break;
@@ -3942,8 +3942,8 @@ export const ES = ObjectAssign({}, ES2020, {
         oneMonthDays = MathAbs(oneMonthDays);
         const divisor = bigInt(oneMonthDays).multiply(dayLengthNs);
         nanoseconds = divisor.multiply(months).plus(bigInt(days).multiply(dayLengthNs)).plus(nanoseconds);
-        const rounded = ES.RoundNumberToIncrement(nanoseconds, divisor * increment, roundingMode);
-        total = nanoseconds.toJSNumber() / divisor;
+        const rounded = ES.RoundNumberToIncrement(nanoseconds, divisor.multiply(increment).toJSNumber(), roundingMode);
+        total = nanoseconds.toJSNumber() / divisor.toJSNumber();
         months = rounded.divide(divisor).toJSNumber();
         nanoseconds = weeks = days = 0;
         break;
@@ -3964,17 +3964,17 @@ export const ES = ObjectAssign({}, ES2020, {
         oneWeekDays = MathAbs(oneWeekDays);
         const divisor = bigInt(oneWeekDays).multiply(dayLengthNs);
         nanoseconds = divisor.multiply(weeks).plus(bigInt(days).multiply(dayLengthNs)).plus(nanoseconds);
-        const rounded = ES.RoundNumberToIncrement(nanoseconds, divisor * increment, roundingMode);
-        total = nanoseconds.toJSNumber() / divisor;
+        const rounded = ES.RoundNumberToIncrement(nanoseconds, divisor.multiply(increment).toJSNumber(), roundingMode);
+        total = nanoseconds.toJSNumber() / divisor.toJSNumber();
         weeks = rounded.divide(divisor).toJSNumber();
         nanoseconds = days = 0;
         break;
       }
       case 'day': {
         const divisor = bigInt(dayLengthNs);
         nanoseconds = divisor.multiply(days).plus(nanoseconds);
-        const rounded = ES.RoundNumberToIncrement(nanoseconds, divisor * increment, roundingMode);
-        total = nanoseconds.toJSNumber() / divisor;
+        const rounded = ES.RoundNumberToIncrement(nanoseconds, divisor.multiply(increment).toJSNumber(), roundingMode);
+        total = nanoseconds.toJSNumber() / divisor.toJSNumber();
         days = rounded.divide(divisor).toJSNumber();
         nanoseconds = 0;
         break;