Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore return value of [Symbol.dispose]() method when hint is 'async-dispose' #180

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Ignore return value of [Symbol.dispose]() method when hint is 'async-dispose' #180

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbc5b2c
Ignore return value of [Symbol.dispose]() method when hint is 'async-…
rbuckton Jun 30, 2023
53635a1
Apply suggestions from PR
rbuckton Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions spec.emu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1068,6 +1068,12 @@ contributors: Ron Buckton, Ecma International
1. Let _method_ be ? GetMethod(_V_, @@asyncDispose).
1. If _method_ is *undefined*, then
1. Set _method_ to ? GetMethod(_V_, @@dispose).
1. Let _closure_ be a new Abstract Closure with no parameters that captures _method_ and performs the following steps when called:
1. Let _O_ be the *this* value.
1. Perform ? Call(_method_, _O_).
1. Return *undefined*.
1. NOTE: This function is not observable to user code. It is used to ensure that a Promise returned from a synchronous `@@dispose` method will not be awaited.
1. Return CreateBuiltinFunction(_closure_, 0, *""*, « »).
rbuckton marked this conversation as resolved.
Show resolved Hide resolved
1. Else,
1. Let _method_ be ? GetMethod(_V_, @@dispose).
1. Return _method_.
Expand Down