Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of ECMA-262 #166

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Update to latest version of ECMA-262 #166

merged 2 commits into from
Mar 22, 2024

Conversation

rbuckton
Copy link
Collaborator

This updates the proposal specification to use the most recent specification text from https://github.com/tc39/ecma262.

@rbuckton rbuckton requested review from syg and waldemarhorwat June 22, 2023 19:09
@github-actions
Copy link

A preview of this PR can be found at https://tc39.es/proposal-explicit-resource-management/pr/166.

@rbuckton
Copy link
Collaborator Author

cc: @tc39/ecma262-editors

@rbuckton rbuckton added the non-normative/editorial Indicates a non-normative/editorial change to the specification label Jun 27, 2023
@rbuckton rbuckton added this to the Stage 4 milestone Jul 19, 2023
@rbuckton rbuckton force-pushed the update-from-ecma262 branch from da7a8e9 to 8e695ea Compare March 20, 2024 19:41
@rbuckton
Copy link
Collaborator Author

This contains no normative changes, merely updates to align with current specification text. All of these changes can already be found in tc39/ecma262#3000 and rbuckton/ecma262#3, so I'd like to merge to get the specification text to agree in both cases. This is likely missing a few recent changes to ecma262 since this PR is 9 months old at this point. @michaelficarra, @syg, @bakkot if one of you could get eyes on this I'd appreciate it. I'd like to close this out today if possible.

Copy link

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what there is to review here, but I can rubber-stamp.

@rbuckton
Copy link
Collaborator Author

rbuckton commented Mar 22, 2024

Just looking for a second pair of eyes to make sure I didn't add a typo

@rbuckton rbuckton merged commit d8db673 into main Mar 22, 2024
1 check passed
@rbuckton rbuckton deleted the update-from-ecma262 branch March 22, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-normative/editorial Indicates a non-normative/editorial change to the specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants