Move BindingPattern restriction for 'using' to an early error #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A preview of this PR can be found at https://tc39.es/proposal-explicit-resource-management/pr/145. |
rbuckton
commented
Jan 30, 2023
spec.emu
Outdated
| <emu-grammar>ForBinding : BindingPattern</emu-grammar> | ||
| <ul> | ||
| <li> | ||
| It is a Syntax Error if this |ForBinding| is contained in a |ForDeclaration| and IsUsingDeclaration of that |ForDeclaration| is *true*. |
There was a problem hiding this comment.
@michaelficarra: Is this sufficient to cover the case of a ForBinding contained in a `for` `(` `var` ForBinding ... production?
There was a problem hiding this comment.
Yeah that seems to work.
rbuckton
force-pushed
the
switch-to-early-errors
branch
from
177ba49 to
1513677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per editor feedback in tc39/proposal-async-explicit-resource-management#9, this moves the BindingPattern restriction for
usingdeclarations to an Early Error to avoid ambiguity from using theUsingparameter in two different ways. The early error condition is roughly equivalent to howconstdeclarations report an early error on a missing Initializer.