Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQs about registration-time snapshotting and alternative snapshots #96

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

shicks
Copy link
Contributor

@shicks shicks commented Jul 4, 2024

I've tried to capture the rationale for why we've been leaning towards registration-time semantics.

@shicks shicks changed the title Add two FAQs about alternative snapshots to the README Add FAQs about registration-time snapshotting and alternative snapshots Jul 4, 2024
Copy link
Member

@andreubotella andreubotella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple nitpicks.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this up! LGTM % nits suggested by Andreu.

README.md Outdated Show resolved Hide resolved
@shicks shicks force-pushed the alternative-snapshots branch from 8b67d7f to 95636d1 Compare July 10, 2024 01:59
@shicks
Copy link
Contributor Author

shicks commented Jul 10, 2024

Updated, thanks for the review.

@legendecas legendecas merged commit 5dae578 into tc39:master Jul 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants