Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Stage 3 Criteria #54

Closed
12 tasks done
ljharb opened this issue May 18, 2023 · 10 comments
Closed
12 tasks done

Stage 3 Criteria #54

ljharb opened this issue May 18, 2023 · 10 comments

Comments

@ljharb
Copy link
Member

ljharb commented May 18, 2023 •
edited
Loading

Reopening #19.
@ljharb ljharb mentioned this issue May 18, 2023
Closed
10 tasks
@jsejcksn jsejcksn mentioned this issue May 19, 2023
Closed
@ljharb ljharb mentioned this issue May 19, 2023
Merged
@michaelficarra
Copy link
Member

Approved.

@nickserv
Copy link

Does this mean it's already stage 3, or is it still blocked by review?

@ljharb
Copy link
Member Author

ljharb commented Jun 17, 2023

@nickmccurdy that means one reviewer approves it. Only plenary can advance stages.

@bricss
Copy link

bricss commented Jun 17, 2023

Those who would like to track 🔍 implementation progress, here is the link 🔗

@ljharb
Copy link
Member Author

ljharb commented Jun 17, 2023

Thanks - that’s just one implementation, but I’ll add it to the stage 4 criteria issue once the proposal is stage 3 :-)

@syg
Copy link

syg commented Jun 19, 2023 •
edited
Loading

Spec lgtm normatively and editorially.

One editorial nit is I'd prefer the coercion parameter in GroupBy to be renamed keyCoercion.

ljharb added a commit that referenced this issue Jun 20, 2023
@ljharb
[spec] rename param, per #54 (comment)
90c5724
@ljharb
Copy link
Member Author

ljharb commented Jun 20, 2023

Nit fixed in 90c5724

@ljharb
Copy link
Member Author

ljharb commented Jul 11, 2023

Stage 3 was approved today, conditional on the remaining review.

@msaboff
Copy link

msaboff commented Jul 11, 2023

Spec lgtm as well.

@ljharb ljharb closed this as completed Jul 11, 2023
@ljharb
Copy link
Member Author

ljharb commented Jul 11, 2023

→ #60

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ljharb @syg @michaelficarra @nickserv @bricss @msaboff