Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Adding style-guide.md with casing conventions explainer. #377

Merged
merged 2 commits into from
Nov 14, 2019
Merged

Editorial: Adding style-guide.md with casing conventions explainer. #377

merged 2 commits into from
Nov 14, 2019

Conversation

sffc
Copy link
Contributor

@sffc sffc commented Sep 21, 2019

@sffc sffc mentioned this pull request Sep 21, 2019
Closed
@sffc
Copy link
Contributor Author

sffc commented Sep 21, 2019

@waldemarhorwat @wycats @domenic @gesa @littledan @leobalter

I would like to adopt this style guide for ECMA-402. It recommends Option 3 from my presentation in July, to use camel case everywhere. As @littledan suggested, these guidelines would be scoped only to ECMA-402 and would not restrict what ECMA-262 could do in the future.

I am adding this to the October agenda in tc39/agendas#622.

@sffc sffc changed the title Adding style-guide.md with casing conventions explainer. Editorial: Adding style-guide.md with casing conventions explainer. Sep 21, 2019
@sffc
Copy link
Contributor Author

sffc commented Sep 23, 2019

Backref: Fixes #363

srl295
srl295 approved these changes Sep 26, 2019
View reviewed changes
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general LGTM but a comment on BCP47

docs/style-guide.md Outdated Show resolved Hide resolved
@leobalter
Copy link
Member

TC39 approved this document during the meeting in 2019-10-02

@leobalter leobalter added the has consensus Has consensus from TC39-TG2 label Oct 2, 2019
@sffc
Copy link
Contributor Author

sffc commented Oct 2, 2019

@waldemarhorwat had some suggestions from TC39; could you leave comments here? Thanks!

@leobalter
Copy link
Member

ping @waldemarhorwat

@sffc
Copy link
Contributor Author

sffc commented Nov 14, 2019

I'm going to merge this. Feedback from @waldemarhorwat can be integrated in a follow-up PR.

@sffc sffc merged commit 95c4552 into tc39:master Nov 14, 2019
@sffc sffc deleted the style-guide branch November 14, 2019 00:02
@snyk-bot snyk-bot mentioned this pull request Feb 24, 2022
Open
@Manny27nyc Manny27nyc mentioned this pull request Jun 30, 2023
Open
This was referenced Nov 28, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leobalter leobalter leobalter approved these changes

@srl295 srl295 srl295 approved these changes

@spectranaut spectranaut Awaiting requested review from spectranaut

@waldemarhorwat waldemarhorwat Awaiting requested review from waldemarhorwat

Assignees
No one assigned
Labels
has consensus Has consensus from TC39-TG2
Projects
ECMA-402 Meeting Topics
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sffc @leobalter @srl295