Normative: Remove arguments.caller poison pill #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bterlson
added
the
needs consensus
|
Well-done spec change--great simplification of the arguments exotic object, happy to have the historical note, and appropriate prohibited extension. Good stuff all around. |
Implementations have not had this extension for many years so continuing to poison pill it is needless. This removes all mention of arguments object's "caller" property with the exception of a note that gives a bit of history (mostly so people can still ctrl+f "caller"). Closes tc39#670.
bterlson
force-pushed
the
remove-arguments-caller
branch
from
15a44e5 to
17da20f
Compare
leobalter
added a commit
to tc39/agendas
that referenced
this pull request
Sep 12, 2016
bterlson
pushed a commit
to tc39/agendas
that referenced
this pull request
Sep 12, 2016
bterlson
removed
the
needs consensus
bakkot
added a commit
to bakkot/ecma262
that referenced
this pull request
Oct 4, 2016
This fixes two pluralization agreement issues introduced by tc39#689.
claudepache
added a commit
to claudepache/ecma262
that referenced
this pull request
Oct 18, 2016
* typo: ``"caller"` → `"caller"` * bug: remove a leftover reference to a special [[HasProperty]] implementation that is gone with tc39#689
bterlson
pushed a commit
that referenced
this pull request
Nov 1, 2016
bterlson
pushed a commit
that referenced
this pull request
Nov 2, 2016
This fixes two pluralization agreement issues introduced by #689.
|
I PR'd a test262 update for this, but I thought we were going to stop merging normative changes until accompanying tests had gone in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementations have not had this extension for many years so continuing
to poison pill it is needless. This removes all mention of arguments
object's "caller" property with the exception of a note that gives a bit
of history (mostly so people can still ctrl+f "caller").
Closes #670.