Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Travis CI to auto update gh-pages (fix #296) #309

Closed
wants to merge 1 commit into from
Closed

Use Travis CI to auto update gh-pages (fix #296) #309

wants to merge 1 commit into from

Conversation

alrra
Copy link
Contributor

@alrra alrra commented Jan 22, 2016

  • Move figure-1.svg and the images from the gh-pages branch (namely: favicon.ico, figure-1.png & figure-2.png ) into img/, and update the build step to copy them into out/.
  • Add a .travis.yml file with configurations to make Travis CI automatically update the content from the gh-pages branch with the content from out/ whenever a change is made in the master branch and the build is successful.

Outdated information was removed.

@bterlson Let me know if I can help you with something, or if I need to change anything.

@bterlson
Copy link
Member

@alrra I will take a look at this tomorrow! But let me say, thanks so much for making this easy for me. It's pretty great you've given me a checklist (with screenshots!).

@annevk
Copy link
Member

annevk commented Jan 22, 2016

❤️

@mathiasbynens
Copy link
Member

👍

In step 2.iii, if you append --add env.global to the command, it will automatically add the key to your .travis.yml file.

@alrra
Copy link
Contributor Author

alrra commented Jan 22, 2016

--add env.global to the command, it will automatically add the key to your .travis.yml file.

The reason why I didn't suggested it was because last night when I tested to see that everything works, --add env.global screwed up the .travis.yml file.

@bterlson
Copy link
Member

This looks mostly good. I would prefer it if the images didn't have a different path in relative to spec.html in the different branches though. I like the img subfolder though, maybe we can just copy the entire folder to gh-pages and update spec.html to point to this location?

@michaelficarra
Copy link
Member

It would make me uncomfortable that I was giving Travis and this npm module access to write to all public repos I own. In my own proposal, I use a deploy key that only has access to that one repo.

@alrra
Copy link
Contributor Author

alrra commented Jan 23, 2016

This looks mostly good. I would prefer it if the images didn't have a different path in relative to spec.html in the different branches though. I like the img subfolder though, maybe we can just copy the entire folder to gh-pages and update spec.html to point to this location?

@bterlson I will update my pull request.

deploy key that only has access to that one repo.

@michaelficarra Thanks for your comment! For some reason I thought there were similar in regards to access. I'll update the Travis script and the information from this pull request.

@@ -15,5 +15,8 @@
"homepage": "https://tc39.github.io/ecma262/",
"dependencies": {
"ecmarkup": "^3.0.0"
},
"devDependencies": {
"@alrra/travis-scripts": "^1.2.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, I would lock down the version of this dependency (and probably npm shrinkwrap) to protect against malicious updates.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locking down dep versions doesn't give you any protection without shrinkwrap, and fails to communicate the intent to follow semver for updates when updating - it'd be best to use a ^ range, and then if you're concerned about updates, npm shrinkwrap --dev on top of that.

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 29, 2016

What's this blocked on?

@michaelficarra
Copy link
Member

Probably this: #309 (comment)

@bterlson
Copy link
Member

Everything now auto-deploys!

@bterlson bterlson closed this Feb 10, 2016
@alrra alrra deleted the fix-296 branch February 10, 2016 22:33
@UltCombo
Copy link
Contributor

Yayy! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants