-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Travis CI to auto update gh-pages
(fix #296)
#309
Conversation
@alrra I will take a look at this tomorrow! But let me say, thanks so much for making this easy for me. It's pretty great you've given me a checklist (with screenshots!). |
❤️ |
👍 In step 2.iii, if you append |
The reason why I didn't suggested it was because last night when I tested to see that everything works, |
This looks mostly good. I would prefer it if the images didn't have a different path in relative to spec.html in the different branches though. I like the img subfolder though, maybe we can just copy the entire folder to gh-pages and update spec.html to point to this location? |
It would make me uncomfortable that I was giving Travis and this npm module access to write to all public repos I own. In my own proposal, I use a deploy key that only has access to that one repo. |
@bterlson I will update my pull request.
@michaelficarra Thanks for your comment! For some reason I thought there were similar in regards to access. I'll update the Travis script and the information from this pull request. |
@@ -15,5 +15,8 @@ | |||
"homepage": "https://tc39.github.io/ecma262/", | |||
"dependencies": { | |||
"ecmarkup": "^3.0.0" | |||
}, | |||
"devDependencies": { | |||
"@alrra/travis-scripts": "^1.2.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, I would lock down the version of this dependency (and probably npm shrinkwrap) to protect against malicious updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
locking down dep versions doesn't give you any protection without shrinkwrap, and fails to communicate the intent to follow semver for updates when updating - it'd be best to use a ^
range, and then if you're concerned about updates, npm shrinkwrap --dev
on top of that.
What's this blocked on? |
Probably this: #309 (comment) |
Everything now auto-deploys! |
Yayy! 👏 |
figure-1.svg
and the images from thegh-pages
branch (namely:favicon.ico
,figure-1.png
&figure-2.png
) intoimg/
, and update the build step to copy them intoout/
..travis.yml
file with configurations to make Travis CI automatically update the content from thegh-pages
branch with the content fromout/
whenever a change is made in themaster
branch and the build is successful.Outdated information was removed.
@bterlson Let me know if I can help you with something, or if I need to change anything.