Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markup: have SDOs use structured headers #2512

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Markup: have SDOs use structured headers #2512

merged 1 commit into from
Sep 21, 2021

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Sep 12, 2021

Depends on tc39/ecmarkup#358 and will not build until that's upstreamed. I've uploaded a rendered version built with that PR here.

This now includes ecmarkup 9.2.0, which introduces support for this.

In a followup, now that the format accommodates it, I'll start adding descriptions and parameter types.

spec.html Show resolved Hide resolved
@bakkot bakkot force-pushed the sdo-descriptions branch 2 times, most recently from acc12ca to 3b8391e Compare September 18, 2021 18:40
@bakkot bakkot marked this pull request as ready for review September 18, 2021 18:40
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Sep 21, 2021
spec.html Outdated Show resolved Hide resolved
spec.html Show resolved Hide resolved
spec.html Show resolved Hide resolved
spec.html Show resolved Hide resolved
spec.html Show resolved Hide resolved
@bakkot bakkot added ready to merge Editors believe this PR needs no further reviews, and is ready to land. and removed ready to merge Editors believe this PR needs no further reviews, and is ready to land. labels Sep 21, 2021
@ljharb ljharb merged commit 1e23cef into master Sep 21, 2021
@ljharb ljharb deleted the sdo-descriptions branch September 21, 2021 05:55
mathiasbynens pushed a commit to mathiasbynens/ecma262 that referenced this pull request Oct 18, 2021
@ljharb ljharb added the markup things that change the spec rendering, but not the contents label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
markup things that change the spec rendering, but not the contents ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants