-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markup: have SDOs use structured headers #2512
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmdyck
reviewed
Sep 17, 2021
bakkot
force-pushed
the
sdo-descriptions
branch
2 times, most recently
from
September 18, 2021 18:40
acc12ca
to
3b8391e
Compare
michaelficarra
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise.
bakkot
added
the
ready to merge
Editors believe this PR needs no further reviews, and is ready to land.
label
Sep 21, 2021
jmdyck
requested changes
Sep 21, 2021
bakkot
added
ready to merge
Editors believe this PR needs no further reviews, and is ready to land.
and removed
ready to merge
Editors believe this PR needs no further reviews, and is ready to land.
labels
Sep 21, 2021
jmdyck
approved these changes
Sep 21, 2021
ljharb
force-pushed
the
sdo-descriptions
branch
from
September 21, 2021 05:52
306a502
to
1e23cef
Compare
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
ljharb
added
the
markup
things that change the spec rendering, but not the contents
label
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
markup
things that change the spec rendering, but not the contents
ready to merge
Editors believe this PR needs no further reviews, and is ready to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on tc39/ecmarkup#358 and will not build until that's upstreamed. I've uploaded a rendered version built with that PR here.This now includes ecmarkup 9.2.0, which introduces support for this.
In a followup, now that the format accommodates it, I'll start adding descriptions and parameter types.