Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: add Reflect[Symbol.toStringTag] #2057

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Jun 19, 2020

Fixes #1970.

Essentially, this PR makes Reflect no longer be the "odd one out" - ie, the only namespace-like builtin object that lacks a Symbol.toStringTag.

See also: tc39/ecma402#430

@ljharb ljharb added normative change Affects behavior required to correctly evaluate some ECMAScript source text needs consensus This needs committee consensus before it can be eligible to be merged. needs test262 tests The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262 labels Jun 19, 2020
@ljharb ljharb requested review from syg, michaelficarra, bakkot and a team June 19, 2020 04:41
ljharb added a commit to tc39/agendas that referenced this pull request Jun 19, 2020
@domenic
Copy link
Member

domenic commented Jul 13, 2020

Just putting a note in here to also discuss the Intl namespace object, when this comes to committee.

@ljharb ljharb added has consensus This has committee consensus. and removed needs consensus This needs committee consensus before it can be eligible to be merged. labels Jul 20, 2020
@ljharb
Copy link
Member Author

ljharb commented Jul 20, 2020

Consensus for this change, as well as the future principle of "consistency" for Intl, and web platform objects, was achieved today at TC39.

@ljharb
Copy link
Member Author

ljharb commented Jul 20, 2020

Tests: tc39/test262#2710

ljharb added a commit to ljharb/test262 that referenced this pull request Jul 20, 2020
leobalter added a commit to tc39/test262 that referenced this pull request Jul 20, 2020
@ljharb ljharb added has test262 tests and removed needs test262 tests The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262 labels Jul 20, 2020
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ljharb ljharb self-assigned this Jul 21, 2020
@ljharb ljharb merged commit 8eab6e8 into tc39:master Jul 21, 2020
@ljharb ljharb deleted the to_string_tags branch July 21, 2020 00:04
domenic pushed a commit to whatwg/webidl that referenced this pull request Jul 23, 2020
A followup to #357.

This change aligns WebIDL namespace objects with ECMA-262 ones, per tc39/ecma262#2057 (comment).

Tests: web-platform-tests/wpt#24717
facebook-github-bot pushed a commit to facebook/hermes that referenced this pull request Jul 25, 2020
Summary: ECMA262 PR: tc39/ecma262#2057

Reviewed By: mhorowitz

Differential Revision: D22737738

fbshipit-source-id: 275a890c5d304bebb83643ebcc6bdf6299dc6898
pull bot pushed a commit to ashu8912/v8 that referenced this pull request Jul 30, 2020
This normative PR reached consensus in the July 2020 TC39:
tc39/ecma262#2057

Bug: v8:10768
Change-Id: Ibe2affea0447b923435f77de5d3c0233deeb9877
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2327753
Commit-Queue: Shu-yu Guo <[email protected]>
Reviewed-by: Marja Hölttä <[email protected]>
Cr-Commit-Position: refs/heads/master@{#69156}
zloirock added a commit to zloirock/core-js that referenced this pull request Nov 4, 2020
JLHwung added a commit to JLHwung/babel-polyfills that referenced this pull request Aug 30, 2021
JLHwung added a commit to JLHwung/babel-polyfills that referenced this pull request Sep 2, 2021
JLHwung added a commit to JLHwung/babel-polyfills that referenced this pull request Sep 7, 2021
JLHwung added a commit to JLHwung/babel-polyfills that referenced this pull request Sep 20, 2021
JLHwung added a commit to babel/babel-polyfills that referenced this pull request Oct 8, 2021
* support new proposals

* update test fixtures

* address review comments

* Add common iterators to Iterator dependencies

* fix JSON stringify polyfill descriptors

* add CommonIterators to (Async)Iterator.from

* support es.string.substr and add es.regexp.exec to matchAll/replaceAll

* add es.regexp.test support

* chore: generate shippedProposals from corejs3 compat data

* support Reflect[@@toStringTag]

tc39/ecma262#2057

* fix typo

* update core-js-compat to 3.17.0

* add global Reflect dependencies

* ignore shipped proposals

* fix: use string version in test fixtures

* update to core-js-compat 3.17.1

* add annex b features

* remove type array instance methods

They are supported in constructor dependencies

* add iterator dependencies to iterator helpers

* fix object.at not polyfilled in pure mode

* esnext.array.unique-by depends on es.map

* chore: update core-js-compat to 3.18.0

* feat: support Array.fromAsync

* Update packages/babel-plugin-polyfill-corejs3/test/check-builtin-definitions.test.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has consensus This has committee consensus. has test262 tests normative change Affects behavior required to correctly evaluate some ECMAScript source text
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconsidering Reflect[Symbol.toStringTag]
4 participants