-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolving merge conflicts #166
Conversation
Fix linter issues
…_push_action Test official docker push action
ci: github action to push md5hash worker to staging
Add ci pip audit
- Added unprivileged python user - Created venv for all pip install - Added chown for all files and dirs - Added --no-install-recommends to apt-get install cmd - Fixed feluda core server.py import issue
Add ci bandit
…kflow_2 Test bandit cron workflow 2
…ron_workflow Add on push bandit cron workflow
Add requests timeout
os.makedirs(os.path.dirname(labels_csv_path), exist_ok=True) | ||
os.system('wget -O "{}" "http://storage.googleapis.com/us_audioset/youtube_corpus/v1/csv/class_labels_indices.csv"'.format(labels_csv_path)) | ||
os.makedirs(os.path.dirname(labels_csv_path), exist_ok=True) | ||
os.system( |
Check failure
Code scanning / Bandit
Starting a process with a shell, possible injection detected, security issue. Error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix later
@@ -80,10 +87,11 @@ | |||
@staticmethod | |||
def make_from_file_in_memory(file_data: FileStorage): | |||
# save on disk | |||
fname = "/tmp/"+file_data.filename | |||
fname = "/tmp/" + file_data.filename |
Check warning
Code scanning / Bandit
Probable insecure usage of temp file/directory. Warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix later
self.assertIsNotNone(result['path']) | ||
self.assertEqual(result['path'], "/tmp/vid.mp4") | ||
self.assertIsNotNone(result["path"]) | ||
self.assertEqual(result["path"], "/tmp/vid.mp4") |
Check warning
Code scanning / Bandit
Probable insecure usage of temp file/directory. Warning test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix later
self.assertIsNotNone(result['path']) | ||
self.assertEqual(result['path'], "/tmp/audio.wav") | ||
self.assertIsNotNone(result["path"]) | ||
self.assertEqual(result["path"], "/tmp/audio.wav") |
Check warning
Code scanning / Bandit
Probable insecure usage of temp file/directory. Warning test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix later
just flagging an error that I got ERROR: Could not install packages due to an OSError: [Errno 13] Permission denied: 'METADATA'
Check the permissions. To fix this error we will have to do pip install as |
fix: Fixed assert issues
fix: Fixed yaml load
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | Generic High Entropy Secret | 3c28a9f | src/reporter.py | View secret | |
2514866 | Triggered | Generic High Entropy Secret | 3670bc9 | src/reporter.py | View secret |
2514866 | Triggered | Generic High Entropy Secret | 11f4186 | src/reporter.py | View secret |
2514866 | Triggered | Generic High Entropy Secret | 8f4e730 | src/reporter.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
No description provided.