Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolving merge conflicts #166

Merged
merged 64 commits into from
Mar 13, 2024
Merged

Conversation

aatmanvaidya
Copy link
Collaborator

No description provided.

duggalsu and others added 30 commits March 7, 2024 12:24
…_push_action

Test official docker push action
ci: github action to push md5hash worker to staging
Automatically generated by python-semantic-release
- Added unprivileged python user
- Created venv for all pip install
- Added chown for all files and dirs
- Added --no-install-recommends to apt-get install cmd
- Fixed feluda core server.py import issue
os.makedirs(os.path.dirname(labels_csv_path), exist_ok=True)
os.system('wget -O "{}" "http://storage.googleapis.com/us_audioset/youtube_corpus/v1/csv/class_labels_indices.csv"'.format(labels_csv_path))
os.makedirs(os.path.dirname(labels_csv_path), exist_ok=True)
os.system(

Check failure

Code scanning / Bandit

Starting a process with a shell, possible injection detected, security issue. Error

Starting a process with a shell, possible injection detected, security issue.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix later

@@ -80,10 +87,11 @@
@staticmethod
def make_from_file_in_memory(file_data: FileStorage):
# save on disk
fname = "/tmp/"+file_data.filename
fname = "/tmp/" + file_data.filename

Check warning

Code scanning / Bandit

Probable insecure usage of temp file/directory. Warning

Probable insecure usage of temp file/directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix later

self.assertIsNotNone(result['path'])
self.assertEqual(result['path'], "/tmp/vid.mp4")
self.assertIsNotNone(result["path"])
self.assertEqual(result["path"], "/tmp/vid.mp4")

Check warning

Code scanning / Bandit

Probable insecure usage of temp file/directory. Warning test

Probable insecure usage of temp file/directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix later

self.assertIsNotNone(result['path'])
self.assertEqual(result['path'], "/tmp/audio.wav")
self.assertIsNotNone(result["path"])
self.assertEqual(result["path"], "/tmp/audio.wav")

Check warning

Code scanning / Bandit

Probable insecure usage of temp file/directory. Warning test

Probable insecure usage of temp file/directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix later

@aatmanvaidya
Copy link
Collaborator Author

just flagging an error that I got

ERROR: Could not install packages due to an OSError: [Errno 13] Permission denied: 'METADATA'
Check the permissions.

To fix this error we will have to do pip install as user

Copy link

gitguardian bot commented Mar 13, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Generic High Entropy Secret 3c28a9f src/reporter.py View secret
2514866 Triggered Generic High Entropy Secret 3670bc9 src/reporter.py View secret
2514866 Triggered Generic High Entropy Secret 11f4186 src/reporter.py View secret
2514866 Triggered Generic High Entropy Secret 8f4e730 src/reporter.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@duggalsu duggalsu merged commit 1dea270 into tattle-made:development Mar 13, 2024
4 of 5 checks passed
@aatmanvaidya aatmanvaidya deleted the temp-dev-2 branch March 13, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants