Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ARM support for Docker Build #89

Merged
merged 2 commits into from
Feb 10, 2024

Conversation

madflojo
Copy link
Member

@madflojo madflojo commented Feb 10, 2024

closes #88

Also adds a docker build and push for tags, which I dunno why was missing.

Summary by CodeRabbit

  • Chores
    • Implemented a new CI job to build and push Docker images for both the main branch and version-tagged commits, supporting multiple platforms.

Copy link
Contributor

coderabbitai bot commented Feb 10, 2024

Warning

Rate Limit Exceeded

@madflojo has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 26 minutes and 12 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 1c918a5 and 55a2dce.

Walkthrough

The recent update introduces a new job in the CI pipeline, specifically designed for building and pushing Docker images. This enhancement caters to different scenarios: one for updates to the main branch and another for tagged releases starting with 'v'. Notably, it includes support for multiple platforms, particularly ARM, addressing requests for broader compatibility.

Changes

File Change Summary
.github/workflows/... Added job for building/pushing Docker images with multi-platform support (amd64, arm64) and conditional tagging

Assessment against linked issues

Objective Addressed Explanation
Add ARM support (#88)

Poem

In the field under the bright lights, two teams clash and fight,
Chiefs and 49ers, in their might, striving for the Super Bowl's delight.
Amidst the cheers, a rabbit hops with glee,
Watching the game, as happy as can be.
"For every pass and tackle, let's cheer,
May the best team win, and their fans revere.
🏈 Let's celebrate this game, with joy and rivalry near!"

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 85cd3de and 1c918a5.
Files selected for processing (1)
  • .github/workflows/docker.yml (2 hunks)
Additional comments: 1
.github/workflows/docker.yml (1)
  • 6-7: Ensure that the tag pattern v* aligns with the project's versioning scheme. If the project uses a different pattern for version tags, adjust accordingly.

.github/workflows/docker.yml Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85cd3de) 81.42% compared to head (55a2dce) 78.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   81.42%   78.13%   -3.29%     
==========================================
  Files          12       13       +1     
  Lines        1308     1363      +55     
==========================================
  Hits         1065     1065              
- Misses        181      236      +55     
  Partials       62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@madflojo madflojo merged commit 4d84ec8 into tarmac-project:main Feb 10, 2024
9 of 11 checks passed
@madflojo madflojo deleted the armsupport branch February 10, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add ARM support
1 participant