-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ARM support for Docker Build #89
Conversation
Warning Rate Limit Exceeded@madflojo has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 26 minutes and 12 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent update introduces a new job in the CI pipeline, specifically designed for building and pushing Docker images. This enhancement caters to different scenarios: one for updates to the main branch and another for tagged releases starting with 'v'. Notably, it includes support for multiple platforms, particularly ARM, addressing requests for broader compatibility. Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/docker.yml (2 hunks)
Additional comments: 1
.github/workflows/docker.yml (1)
- 6-7: Ensure that the tag pattern
v*
aligns with the project's versioning scheme. If the project uses a different pattern for version tags, adjust accordingly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 81.42% 78.13% -3.29%
==========================================
Files 12 13 +1
Lines 1308 1363 +55
==========================================
Hits 1065 1065
- Misses 181 236 +55
Partials 62 62 ☔ View full report in Codecov by Sentry. |
closes #88
Also adds a docker build and push for tags, which I dunno why was missing.
Summary by CodeRabbit