Small log additions and moving metrics from Seconds to Milliseconds #80
Conversation
|
Warning Rate Limit Exceeded@madflojo has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 10 minutes and 24 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the @coderabbitai review command. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Your existing content is already well-structured and captures the required information. I'll repeat it verbatim without additional text: WalkthroughThe recent updates to the server application focus on enhancing the precision of logging and observation metrics by shifting from seconds to milliseconds. This change affects how the application logs HTTP requests, PProf handling, and the execution of WebAssembly (WASM) modules, providing more granular insight into the performance and duration of these operations. Changes
Poem
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (1)
- pkg/app/server.go (3 hunks)
Additional comments: 1
pkg/app/server.go (1)
- 55-64: The changes correctly log an attempt to access PProf when it is disabled and respond with a
StatusForbidden. This is a good security practice as it logs unauthorized access attempts. Ensure that theenable_pprofconfiguration is properly documented and that the system administrators are aware of this feature.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
+ Coverage 83.03% 83.14% +0.11%
==========================================
Files 12 12
Lines 1167 1181 +14
==========================================
+ Hits 969 982 +13
- Misses 152 153 +1
Partials 46 46 ☔ View full report in Codecov by Sentry. |
madflojo
changed the title
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (2)
- pkg/app/app.go (2 hunks)
- pkg/app/server.go (2 hunks)
Additional comments: 3
pkg/app/server.go (3)
48-52:
The change to include "received" in the log message is implemented correctly. However, ensure that the removal of headers from the logs is consistent with the pull request's goal of not logging sensitive information.55-67:
The change to log the duration in milliseconds when PProf is disabled is implemented correctly. However, ensure that theObservemethod is correctly handling milliseconds since this is a change from the previous behavior.138-159:
The changes to log the execution duration of WASM modules in milliseconds and to include additional details such as the "module" and "handler" are implemented correctly. Ensure that theObservemethod is correctly handling milliseconds and that the logging changes do not introduce any performance issues.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- pkg/app/app.go (2 hunks)
Additional comments: 2
pkg/app/app.go (2)
328-357:
The changes to log and observe callback execution times in milliseconds are correctly implemented and consistent with the pull request's goals.
[APROVED]511-517:
The implementation of task execution time observation in milliseconds after error checking is correct and does not result in double counting.
This removes headers from logs, as sometimes headers might hold secrets that shouldn't be logged. Also adds time to logs.
Summary by CodeRabbit
Refactor
Bug Fixes