Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): adding a latest tag to releases #108

Merged
merged 1 commit into from
May 25, 2024

Conversation

madflojo
Copy link
Member

@madflojo madflojo commented May 25, 2024

This, in theory (YOLO), will add the latest tag to the release build if the release is the latest and greatest.

Summary by CodeRabbit

  • Chores
    • Improved CI/CD workflow to conditionally tag Docker images as latest based on version comparison.

Copy link
Contributor

coderabbitai bot commented May 25, 2024

Walkthrough

The workflow file .github/workflows/docker.yml was updated to improve the tagging mechanism during the Docker build and push process. A new step was added to ensure all tags are fetched when checking out the code. Additionally, the tags field logic was modified to conditionally include the madflojo/tarmac:latest tag based on a comparison between the latest_tag and current_tag.

Changes

File Change Summary
.github/workflows/docker.yml - Added a step to checkout code and fetch all tags.
- Modified the tags field to conditionally include madflojo/tarmac:latest based on tag comparison.

🐰
A rabbit hopped through lines of code,
Ensuring tags in sync and mode.
With latest fetched and logic keen,
The Docker flow now runs pristine.
In fields of bytes, the changes bloom,
As pipelines hum a cheerful tune.
🐇✨

Tip

New Features and Improvements

Review Settings

Introduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments.

AST-based Instructions

CodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation.

Community-driven AST-based Rules

We are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information.

New Static Analysis Tools

We are continually expanding our support for static analysis tools. We have added support for biome, hadolint, and ast-grep. Update the settings in your .coderabbit.yaml file or head over to the settings page to enable or disable the tools you want to use.

Tone Settings

Users can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:

  • Mr. T: "You must talk like Mr. T in all your code reviews. I pity the fool who doesn't!"
  • Pirate: "Arr, matey! Ye must talk like a pirate in all yer code reviews. Yarrr!"
  • Snarky: "You must be snarky in all your code reviews. Snark, snark, snark!"

Revamped Settings Page

We have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to .coderabbit.yaml will be reflected in the settings page, and vice versa.

Miscellaneous

  • Turn off free summarization: You can switch off free summarization of PRs opened by users not on a paid plan using the enable_free_tier setting.
  • Knowledge-base scope: You can now set the scope of the knowledge base to either the repository (local) or the organization (global) level using the knowledge_base setting. In addition, you can specify Jira project keys and Linear team keys to limit the knowledge base scope for those integrations.
  • High-level summary placement: You can now customize the location of the high-level summary in the PR description using the high_level_summary_placeholder setting (default @coderabbitai summary).
  • Revamped request changes workflow: You can now configure CodeRabbit to auto-approve or request changes on PRs based on the review feedback using the request_changes_workflow setting.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 1eadcda and dc3af62.
Files selected for processing (1)
  • .github/workflows/docker.yml (2 hunks)
Additional comments not posted (2)
.github/workflows/docker.yml (2)

42-44: Check the conditional logic for tagging the Docker image as "latest".

Verification successful

Let's verify if the environment variables latest_tag and current_tag are being set correctly in the workflow file.


The environment variables latest_tag and current_tag are set correctly in the workflow file, and the conditional logic for tagging the Docker image as "latest" is implemented correctly.

  • The environment variables are set using:
    • echo "current_tag=$(echo ${GITHUB_REF#refs/tags/})" >> $GITHUB_ENV
    • echo "latest_tag=$(git describe --tags \git rev-list --tags --max-count=1`)" >> $GITHUB_ENV`
  • The conditional logic for tagging the Docker image as "latest" is:
    • ${{ env.latest_tag == env.current_tag && 'madflojo/tarmac:latest' }}
Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the conditional logic for applying the "latest" tag.

# Test: Simulate the condition to ensure it correctly applies the "latest" tag when `latest_tag` equals `current_tag`.
if [ "$latest_tag" == "$current_tag" ]; then
  echo "Tagging as latest"
else
  echo "Not tagging as latest"
fi

Length of output: 63



Script:

#!/bin/bash
# Search for the environment variable assignments in the workflow file
grep -E 'latest_tag|current_tag' .github/workflows/docker.yml

Length of output: 323


29-33: Ensure that the environment variables current_tag and latest_tag are correctly set.

@madflojo madflojo merged commit 445d394 into tarmac-project:main May 25, 2024
8 checks passed
@madflojo madflojo deleted the add-latest-tag branch May 25, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant