Skip to content

Commit

Permalink
test: stop testing --interpreted-frames-native-stack for s390x
Browse files Browse the repository at this point in the history
V8 does not support the flag on this architecture anymore.

Backport-PR-URL: nodejs#33376
PR-URL: nodejs#32831
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
  • Loading branch information
targos committed May 26, 2020
1 parent 5045aaf commit 38fd93c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/parallel/test-cli-node-options.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ expect('--stack-trace-limit=100',
/(\s*at f \(\[(eval|worker eval)\]:1:\d*\)\r?\n)/,
'(function f() { f(); })();',
true);
// Unsupported on arm. See https://crbug.com/v8/8713.
if (!['arm', 'arm64'].includes(process.arch))
// Unsupported on arm and s390. See https://crbug.com/v8/8713.
if (!['arm', 'arm64', 's390x'].includes(process.arch))
expect('--interpreted-frames-native-stack', 'B\n');

function expectNoWorker(opt, want, command, wantsError) {
Expand Down

0 comments on commit 38fd93c

Please sign in to comment.